Closed Bug 957093 Opened 6 years ago Closed 6 years ago

all netwerk/protocol/http* live in mozilla::net

Categories

(Core :: Networking: HTTP, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

Attachments

(1 file)

bring some consistency to the namespaces here by converting legacy classes. this is just a subset of netwerk/* but its a good start.
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Comment on attachment 8356535 [details] [diff] [review]
namespace consistency for netwerk/protocol/http

Review of attachment 8356535 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Couple of really minor nits about indentation. I won't mind if you want to ignore them ;) r=me.

::: netwerk/protocol/http/nsHttpConnection.h
@@ +262,5 @@
>  
>      // version level in use, 0 if unused
>      uint8_t                         mUsingSpdyVersion;
>  
> +    nsRefPtr<ASpdySession> mSpdySession;

nit: indentation.

::: netwerk/protocol/http/nsHttpHandler.h
@@ +455,5 @@
>      bool           mCriticalRequestPrioritization;
>  
>      // When the disk cache is responding slowly its use is suppressed
>      // for 1 minute for most requests.
> +    TimeStamp                mCacheSkippedUntil;

nit: indentation to match mCriticalRequestPrioritization?
Attachment #8356535 - Flags: review?(sworkman) → review+
https://hg.mozilla.org/mozilla-central/rev/495387c38734
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.