957093 - all netwerk/protocol/http* live in mozilla::net

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

bring some consistency to the namespaces here by converting legacy classes. this is just a subset of netwerk/* but its a good start.

Comment 1

[Patrick McManus [:mcmanus]]

https://tbpl.mozilla.org/?tree=Try&rev=1b53cc2d9792

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: namespace consistency for netwerk/protocol/http

Comment 3

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8356535 [details] [diff] [review]
namespace consistency for netwerk/protocol/http

Review of attachment 8356535 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Couple of really minor nits about indentation. I won't mind if you want to ignore them ;) r=me.

::: netwerk/protocol/http/nsHttpConnection.h
@@ +262,5 @@
>  
>      // version level in use, 0 if unused
>      uint8_t                         mUsingSpdyVersion;
>  
> +    nsRefPtr<ASpdySession> mSpdySession;

nit: indentation.

::: netwerk/protocol/http/nsHttpHandler.h
@@ +455,5 @@
>      bool           mCriticalRequestPrioritization;
>  
>      // When the disk cache is responding slowly its use is suppressed
>      // for 1 minute for most requests.
> +    TimeStamp                mCacheSkippedUntil;

nit: indentation to match mCriticalRequestPrioritization?

Comment 4

[Patrick McManus [:mcmanus]]

nits addressed

https://hg.mozilla.org/integration/mozilla-inbound/rev/495387c38734

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/495387c38734