Status

Firefox OS
Gaia::UI Tests
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zac, Assigned: bsilverberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 obsolete attachments)

(Reporter)

Description

5 years ago
There are a few more new tests that can be enabled on TBPL.

You'll have to go through and work out which ones can be enabled and then enable them in tbpl-manifest.ini

Then once merged, watch TBPL and make sure they pass. 

Be prepared to back out the patch if they fail on TBPL.
(Assignee)

Updated

5 years ago
Assignee: nobody → bob.silverberg
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 8359438 [details] [review]
Add/enable two tests for Calendar app on TBPL

Whoever merges this needs to watch TBPL to make sure that Gu is still green.
Attachment #8359438 - Flags: review?(zcampbell)
Attachment #8359438 - Flags: review?(viorela.ioia)
Attachment #8359438 - Flags: review?(trifandreialin)
Attachment #8359438 - Flags: review?(florin.strugariu)
Attachment #8359438 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 2

5 years ago
Note that I am going to submit a number of separate PRs for tests that I find that can be enabled to make backing out simpler if there is a failure.
(Assignee)

Comment 3

5 years ago
Created attachment 8359445 [details] [review]
PR for a new Gallery test on TBPL and also enabling it on Travis

Please watch Gu on TBPL after merging to ensure the test passes.
Attachment #8359445 - Flags: review?(zcampbell)
Attachment #8359445 - Flags: review?(viorela.ioia)
Attachment #8359445 - Flags: review?(trifandreialin)
Attachment #8359445 - Flags: review?(florin.strugariu)
Attachment #8359445 - Flags: review?(andrei.hutusoru)
Attachment #8359438 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8359445 [details] [review]
PR for a new Gallery test on TBPL and also enabling it on Travis

See comments in the PR
Attachment #8359445 - Flags: review?(viorela.ioia) → review-
(Assignee)

Comment 5

5 years ago
Comment on attachment 8359445 [details] [review]
PR for a new Gallery test on TBPL and also enabling it on Travis

This won't work currently.
Attachment #8359445 - Attachment is obsolete: true
Attachment #8359445 - Flags: review?(zcampbell)
Attachment #8359445 - Flags: review?(trifandreialin)
Attachment #8359445 - Flags: review?(florin.strugariu)
Attachment #8359445 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 6

5 years ago
Created attachment 8359793 [details] [review]
Pull request to add 2 keyboard tests

Please watch the Gu component on TBPL after merging to ensure the tests pass.
Attachment #8359793 - Flags: review?(zcampbell)
Attachment #8359793 - Flags: review?(viorela.ioia)
Attachment #8359793 - Flags: review?(trifandreialin)
Attachment #8359793 - Flags: review?(florin.strugariu)
Attachment #8359793 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 7

5 years ago
Created attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

Please watch Gu on TBPL after merging.
Attachment #8359798 - Flags: review?(zcampbell)
Attachment #8359798 - Flags: review?(viorela.ioia)
Attachment #8359798 - Flags: review?(trifandreialin)
Attachment #8359798 - Flags: review?(florin.strugariu)
Attachment #8359798 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 8

5 years ago
Created attachment 8359802 [details] [review]
Enable test_sms_add_contact and test_sms_to_settings on TBPL

Please watch Gu on TBPL after merging.
Attachment #8359802 - Flags: review?(zcampbell)
Attachment #8359802 - Flags: review?(viorela.ioia)
Attachment #8359802 - Flags: review?(trifandreialin)
Attachment #8359802 - Flags: review?(florin.strugariu)
Attachment #8359802 - Flags: review?(andrei.hutusoru)
Attachment #8359798 - Flags: review?(viorela.ioia) → review+
Attachment #8359802 - Flags: review?(viorela.ioia) → review+
Attachment #8359793 - Flags: review?(viorela.ioia) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 8359962 [details] [review]
Enable test_settings_app_permissions on TBPL

Please watch Gu on TBPL after merging.
Attachment #8359962 - Flags: review?(zcampbell)
Attachment #8359962 - Flags: review?(viorela.ioia)
Attachment #8359962 - Flags: review?(trifandreialin)
Attachment #8359962 - Flags: review?(florin.strugariu)
Attachment #8359962 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 10

5 years ago
Created attachment 8359964 [details] [review]
Enable test_context_menu_activity_picker on TBPL

Please watch the Gu component on TBPL after merging.
Attachment #8359964 - Flags: review?(zcampbell)
Attachment #8359964 - Flags: review?(viorela.ioia)
Attachment #8359964 - Flags: review?(trifandreialin)
Attachment #8359964 - Flags: review?(florin.strugariu)
Attachment #8359964 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 11

5 years ago
Created attachment 8359968 [details] [review]
Enable test_prefs on TBPL

Please watch Gu on TBPL after merging
Attachment #8359968 - Flags: review?(zcampbell)
Attachment #8359968 - Flags: review?(viorela.ioia)
Attachment #8359968 - Flags: review?(trifandreialin)
Attachment #8359968 - Flags: review?(florin.strugariu)
Attachment #8359968 - Flags: review?(andrei.hutusoru)
(Assignee)

Comment 12

5 years ago
I have finished reviewing the existing tests for candidates to be run on TBPL. Once all of the above patches are merged and/or rejected this bug can be closed.
Comment on attachment 8359438 [details] [review]
Add/enable two tests for Calendar app on TBPL

r+
Merged in:
https://github.com/mozilla-b2g/gaia/commit/f3a54267320cc063215d01fad7deb1a6c891b27d
Attachment #8359438 - Flags: review?(zcampbell)
Attachment #8359438 - Flags: review?(trifandreialin)
Attachment #8359438 - Flags: review?(florin.strugariu)
Attachment #8359438 - Flags: review?(andrei.hutusoru)
Attachment #8359438 - Flags: review+
Comment on attachment 8359793 [details] [review]
Pull request to add 2 keyboard tests

r+
Merged in:
https://github.com/mozilla-b2g/gaia/commit/98f4e82b193d0f625c4a7dccc65e32782ecfaf4e
Attachment #8359793 - Flags: review?(zcampbell)
Attachment #8359793 - Flags: review?(trifandreialin)
Attachment #8359793 - Flags: review?(florin.strugariu)
Attachment #8359793 - Flags: review?(andrei.hutusoru)
Attachment #8359793 - Flags: review+
Attachment #8359962 - Flags: review?(viorela.ioia) → review+
Attachment #8359968 - Flags: review?(viorela.ioia) → review+
Attachment #8359964 - Flags: review?(viorela.ioia) → review+
(Assignee)

Updated

5 years ago
Attachment #8359438 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #8359793 - Attachment is obsolete: true
Comment on attachment 8359968 [details] [review]
Enable test_prefs on TBPL

r+
merged in:
https://github.com/mozilla-b2g/gaia/commit/1307a485358cf8f7db6e92ae563d169b4e4c98e1
Attachment #8359968 - Flags: review?(zcampbell)
Attachment #8359968 - Flags: review?(trifandreialin)
Attachment #8359968 - Flags: review?(florin.strugariu)
Attachment #8359968 - Flags: review?(andrei.hutusoru)
Attachment #8359968 - Flags: review+
Comment on attachment 8359802 [details] [review]
Enable test_sms_add_contact and test_sms_to_settings on TBPL

r+
merged in:
https://github.com/mozilla-b2g/gaia/commit/c8f2c2a666c3cdcae2f241fa0dfbcc13c494d1f6
Attachment #8359802 - Flags: review?(zcampbell)
Attachment #8359802 - Flags: review?(trifandreialin)
Attachment #8359802 - Flags: review?(florin.strugariu)
Attachment #8359802 - Flags: review?(andrei.hutusoru)
Attachment #8359802 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #8359802 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #8359968 - Attachment is obsolete: true
(Reporter)

Comment 19

5 years ago
Now bug 891882 is resolved we can enable even more TBPL tests :)
Comment on attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

Can you fix the merge conflicts
Attachment #8359798 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8359962 [details] [review]
Enable test_settings_app_permissions on TBPL

merge conflicts
Attachment #8359962 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8359964 [details] [review]
Enable test_context_menu_activity_picker on TBPL

LGTM

I will merge this and fallow the results on TBPL
Attachment #8359964 - Flags: review?(zcampbell)
Attachment #8359964 - Flags: review?(trifandreialin)
Attachment #8359964 - Flags: review?(florin.strugariu)
Attachment #8359964 - Flags: review?(andrei.hutusoru)
Attachment #8359964 - Flags: review+
(Reporter)

Comment 25

5 years ago
Comment on attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

r+

and Merged:
https://github.com/mozilla-b2g/gaia/commit/becb06a2d473def2233e87bc54d5431664517164
Attachment #8359798 - Flags: review?(zcampbell)
Attachment #8359798 - Flags: review?(trifandreialin)
Attachment #8359798 - Flags: review?(andrei.hutusoru)
Attachment #8359798 - Flags: review+
(Reporter)

Comment 26

5 years ago
Comment on attachment 8359962 [details] [review]
Enable test_settings_app_permissions on TBPL

r+
and merged:
https://github.com/mozilla-b2g/gaia/commit/6d1872b8abd38afe73e6bd3ba32d47d104d0cbbd
Attachment #8359962 - Flags: review?(zcampbell)
Attachment #8359962 - Flags: review?(trifandreialin)
Attachment #8359962 - Flags: review?(andrei.hutusoru)
Attachment #8359962 - Flags: review+
(Assignee)

Comment 27

5 years ago
Comment on attachment 8359798 [details] [review]
Enable test_lockscreen_wake_with_notification on TBPL

Landed in https://github.com/bobsilverberg/gaia/commit/00e9b7e4dd772e84fdafebbf7a2f7ccd3f69f081
(Assignee)

Comment 28

5 years ago
Oops, not only did I not need to add that comment, it also points at the wrong commit.  Ignore me. :(
(Assignee)

Updated

5 years ago
Attachment #8359962 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #8359798 - Attachment is obsolete: true
(Assignee)

Comment 29

5 years ago
All of the PRs I opened for this bug have been merged, so I'm going to mark this as fixed. Perhaps we should open another, or reopen this in a month or so to go through the exercise again? Although davehunt also mentioned that he'd like to get rid of the two-manifest system, which should remove the need to do this in the future.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.