Closed Bug 957141 Opened 6 years ago Closed 6 years ago

[v1.3] Fix failure in test_settings_airplane_mode

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: viorela, Assigned: viorela)

Details

Attachments

(1 file)

Traceback (most recent call last):
  File "/home/viorelaioia/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/viorelaioia/WebQA/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_airplane_mode.py", line 30, in test_toggle_airplane_mode
    self.assertFalse(self.data_layer.is_wifi_connected(self.testvars['wifi']), "WiFi was still connected after switching on Airplane mode")
TEST-UNEXPECTED-FAIL | test_settings_airplane_mode.py test_settings_airplane_mode.TestAirplaneMode.test_toggle_airplane_mode | AssertionError: WiFi was still connected after switching on Airplane mode
Summary: Fix failure in test_settings_airplane_mode → [v1.3] Fix failure in test_settings_airplane_mode
Assignee: nobody → viorela.ioia
Attachment #8356583 - Flags: review?(trifandreialin)
Attachment #8356583 - Flags: review?(florin.strugariu)
Attachment #8356583 - Flags: review?(andrei.hutusoru)
Comment on attachment 8356583 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/15071

r+
Attachment #8356583 - Flags: review?(trifandreialin) → review+
Comment on attachment 8356583 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/15071

I think we should have both conditions in there 
at some point I'm sure we will see a fail with the cell data so let's keep them both
Attachment #8356583 - Flags: review?(florin.strugariu) → review-
We worked on this in master branch recently.

This may be a case where you can copy the logic from the master branch safely.
It is the same fix we used on master branch.
Attachment #8356583 - Flags: review- → review+
merged in https://github.com/mozilla-b2g/gaia/commit/137771293849356f8ac05ecc62241b040685294e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8356583 - Flags: review?(andrei.hutusoru)
You need to log in before you can comment on or make changes to this bug.