Closed Bug 957151 Opened 6 years ago Closed 6 years ago

Fix home button styling in bookmarks bar on Linux

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 31
Tracking Status
firefox29 --- verified
firefox30 --- verified
firefox31 --- verified

People

(Reporter: Gijs, Assigned: mikedeboer)

References

Details

(Whiteboard: [Australis:P4])

Attachments

(1 file)

Spun off from bug 940107.
Screenshot? Not sure how severe this is.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Justin Dolske [:Dolske] from comment #1)
> Screenshot? Not sure how severe this is.

You can see screenshot at https://bugzilla.mozilla.org/show_bug.cgi?id=940107
Hardware: x86 → x86_64
Screen shot of Aurora with missing home icon.

http://imgur.com/q1OGjFD
Flags: needinfo?(gijskruitbosch+bugs)
Still missing in Firefox 29.0b1
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Depends on: 987461
Attachment #8398547 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed: https://hg.mozilla.org/integration/fx-team/rev/722363d66998
Whiteboard: [Australis:P4] → [Australis:P4][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/722363d66998
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][fixed-in-fx-team] → [Australis:P4]
Target Milestone: --- → Firefox 31
Comment on attachment 8398547 [details] [diff] [review]
Patch v1: fix styling of primary toolbar buttons on the bookmarks toolbar

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 957151, Australis
User impact if declined: User will see the wrong/ broken styling of the Home button when placed on the Bookmarks toolbar.
Testing completed (on m-c, etc.): landed on m-c.
Risk to taking this patch (and alternatives if risky): minor.
String or IDL/UUID changes made by this patch: n/a
Attachment #8398547 - Flags: approval-mozilla-beta?
Attachment #8398547 - Flags: approval-mozilla-aurora?
Attachment #8398547 - Flags: approval-mozilla-beta?
Attachment #8398547 - Flags: approval-mozilla-beta+
Attachment #8398547 - Flags: approval-mozilla-aurora?
Attachment #8398547 - Flags: approval-mozilla-aurora+
Keywords: verifyme
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0

Verified as fixed using Firefox 29 beta 4 (20140331125246), Aurora 30.0a2 (20140401004001) and Nightly 31.0a1 (20140331030201) under Ubuntu 32-bit.
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Contact: petruta.rasa
You need to log in before you can comment on or make changes to this bug.