Closed
Bug 957160
Opened 10 years ago
Closed 10 years ago
DevTools Themes: Use 2x icon for split console on tab bar
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(5 files, 3 obsolete files)
2.32 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
1.34 KB,
image/png
|
Details | |
629 bytes,
image/png
|
Details | |
42.17 KB,
image/png
|
dhenein
:
ui-review+
|
Details |
2.31 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
This is the last 1x icon in use in the top tab bar after Bug 947309.
Assignee | ||
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Darrin, can you please provide the 2x version of the split console command icon?
Flags: needinfo?(dhenein)
Comment 2•10 years ago
|
||
Flags: needinfo?(dhenein)
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Light versions coming...
Assignee | ||
Comment 5•10 years ago
|
||
Screenshot of commands with new icon
Assignee | ||
Comment 6•10 years ago
|
||
Patrick, this patch just replaces the existing icon with the new one (already referenced in jar.mn with the new version).
Attachment #8356617 -
Flags: review?(pbrosset)
Updated•10 years ago
|
Attachment #8356617 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2fcf4c085473 https://tbpl.mozilla.org/?tree=Fx-Team&rev=2fcf4c085473
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•10 years ago
|
Whiteboard: [fixed-in-fx-team] → [leave open][fixed-in-fx-team]
Comment 8•10 years ago
|
||
Attachment #8356612 -
Attachment is obsolete: true
Comment 9•10 years ago
|
||
Attachment #8356613 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
Screenshot with the updated icon
Attachment #8356615 -
Attachment is obsolete: true
Attachment #8356637 -
Flags: ui-review?(dhenein)
Comment 11•10 years ago
|
||
Comment on attachment 8356637 [details]
Screenshot 2014-01-07 11.56.12.png
Beauty, thanks!
Attachment #8356637 -
Flags: ui-review?(dhenein) → ui-review+
Assignee | ||
Comment 12•10 years ago
|
||
Just updating the binary file to reflect Attachment 8356637 [details] (a pixel or two lower than before).
Attachment #8356659 -
Flags: review?(pbrosset)
Updated•10 years ago
|
Attachment #8356659 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5b9009fc551a https://tbpl.mozilla.org/?tree=Fx-Team&rev=5b9009fc551a
Whiteboard: [leave open][fixed-in-fx-team] → [fixed-in-fx-team]
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2fcf4c085473
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•