Closed Bug 957160 Opened 7 years ago Closed 7 years ago

DevTools Themes: Use 2x icon for split console on tab bar

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(5 files, 3 obsolete files)

This is the last 1x icon in use in the top tab bar after Bug 947309.
OS: Mac OS X → All
Hardware: x86 → All
Status: NEW → ASSIGNED
Darrin, can you please provide the 2x version of the split console command icon?
Flags: needinfo?(dhenein)
Attached image @2x icon (obsolete) —
Flags: needinfo?(dhenein)
Attached image @1x icon (obsolete) —
Light versions coming...
Attached image command-console-2x.png (obsolete) —
Screenshot of commands with new icon
Patrick, this patch just replaces the existing icon with the new one (already referenced in jar.mn with the new version).
Attachment #8356617 - Flags: review?(pbrosset)
Attachment #8356617 - Flags: review?(pbrosset) → review+
Whiteboard: [fixed-in-fx-team] → [leave open][fixed-in-fx-team]
Attached image @2x icon
Attachment #8356612 - Attachment is obsolete: true
Attached image @1x icon
Attachment #8356613 - Attachment is obsolete: true
Screenshot with the updated icon
Attachment #8356615 - Attachment is obsolete: true
Attachment #8356637 - Flags: ui-review?(dhenein)
Comment on attachment 8356637 [details]
Screenshot 2014-01-07 11.56.12.png

Beauty, thanks!
Attachment #8356637 - Flags: ui-review?(dhenein) → ui-review+
Just updating the binary file to reflect Attachment 8356637 [details] (a pixel or two lower than before).
Attachment #8356659 - Flags: review?(pbrosset)
Attachment #8356659 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/2fcf4c085473
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.