957167 - MetroFX crash prompt: Allow positioning privacy policy link at arbitrary position in sentence

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, enhancement)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

+++ This bug was initially created as a clone of Bug #951802 +++

At the moment, the crashreporter has the following text:

<!ENTITY crashprompt.detailedMessage.thirdParagraph "We use crash reports to try to fix problems and improve our products. We handle your information as we describe in our ">
<!ENTITY crashprompt.privacyPolicyLink "&brandShortName; privacy policy">

This means the privacy policy has always to be at the end of the sentence which is problematic for localization.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

We could do this by splitting the "crashprompt.detailedMessage.thirdParagraph" entity here [1] into "crashprompt.detailedMessage.thirdParagraphBeforeLink" and "crashprompt.detailedMessage.thirdParagraphAfterLink"

Then, in [2] we would replace "&crashprompt.detailedMessage.thirdParagraph;" with "&crashprompt.detailedMessage.thirdParagraphBeforeLink;" and add "&crashprompt.detailedMessage.thirdParagraphAfterLink;" after the link.

[1] https://mxr.mozilla.org/mozilla-central/source/browser/metro/locales/en-US/chrome/crashprompt.dtd?rev=b44cec692a98
[2] https://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/pages/crashprompt.xhtml?rev=b44cec692a98#103

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8356628 [details] [diff] [review]
patch, v1

The patch in its current style would also cause trouble because inline content spans over several rows in the source code and linebreaks get converted to whitespaces. Removing the linebreaks and leading whitespaces would create a line of 223 characters. Should the content be generated by a script?

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

I don't mind removing the linebreaks and having a long line, but needinfoing Matt in case he has a better suggestion

Comment 5

[(no longer active)]

You can just break the DTD entries into multiple lines.  See aboutTelemetry.dtd for examples.

Comment 6

[Matt Brubeck (:mbrubeck)]

In this case it's the XML content rather than the DTD where linebreaks are a problem.

I'm fine with one 223-char line here, or alternately I think you can put the whitespace into comment nodes, like:

  &before;<!--
  --><a>&link;</a><!--
  -->&after;

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v2

Thanks for the suggestion, mbrubeck.

Comment 8

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8356840 [details] [diff] [review]
patch, v2

Review of attachment 8356840 [details] [diff] [review]:
-----------------------------------------------------------------

Applied patch and verified that it works for me. Code looks good as well.

Can we have :flod take a look and make sure he likes this approach?

Comment 9

[Francesco Lodolo [:flod]]

My only suggestion would be to add a localization comment in the .dtd explaining that those 3 strings will be used together to create a single sentence.

Comment 10

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Francesco Lodolo [:flod] from comment #9)
> My only suggestion would be to add a localization comment in the .dtd
> explaining that those 3 strings will be used together to create a single
> sentence.

Sounds good!

:aryx - feel free to add the comment and carry forward my r+

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v3, r=tabraldes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2fc2df126ccd

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2fc2df126ccd