957168 - Context menu for dir links in search results

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect, P1)

Description

[Erik Rose [:erik][:erikrose]]

In the production DXR, clicking a directory name in the search results spawns a pop-up menu from which you can choose to browse that dir, limit the search to that dir, or exclude that dir from the search. We should preserve that feature.

Comment 1

[Erik Rose [:erik][:erikrose]]

While you're at it, the icons next to directory names in the search results are wrong: they look like files. And, since they don't add any information (every non-leaf node being of course a directory), let's omit them. We can leave the icon for the final file; that could conceivably be useful.

Comment 2

[Erik Rose [:erik][:erikrose]]

Note that the multiple icons appear only when using search.html (pressing Return). They don't show up when doing find-as-you-type. We really should have only one code path for this so we don't have this sort of divergent bug. Maybe we could always do the search-result templating on the client side [someday]. (In the 6-months-or-later future, I see DXR become pretty much a single-page app, pulling things via AJAX as necessary. That'll save us a lot of state-squirreling, as with the Case-sensitive checkbox, giving us better UI stability.)

Comment 3

[[github robot]]

Commit pushed to ui at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/20b4985ab8e9e1d3fdab779dbacc849393b60c37
Merge branch 'bug957168-context-menu-for-dir-links' into ui. Fixes Bug 957168 and other small UI tweaks.