957175 - Reduce the number of relocations needed for NamesOfInterfacesWithProtos

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See discussion in bug 956806 comment 13 through bug 956806 comment 16.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Might be best (smallest) to just generate a single string with all the names in it, and generate a separate table of offsets into that string.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: reduce relocations required by NamesOfInterfacesWithProtos

Hooray for string tables.

This compiles fine with GCC, but I think at one point GCC used to complain
about \0 in string constants.  May have to take a different tack if B2G builds
complain, or if other compilers are pedantic as well.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8373361 [details] [diff] [review]
reduce relocations required by NamesOfInterfacesWithProtos

>+        return "extern const char *%s(unsigned int aIndex);\n\n" % self.accessorName

I'd prefer we drop the trailing \n here and have the caller insert them as needed.  That lets the caller control its own spacing.  Yes, we're not very consistent about that sort of thing right now.  :(  Simply making the CGList in the caller use "\n\n" instead of "\n" as the list separator might be good here.

>+        return """
>+const char *%s(unsigned int aIndex)

Please drop the leading newline here?

r=me

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/241a7157196c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/241a7157196c