957187 - The variable inspection popup never appears in the right place on Linux and Windows

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

This is driving me Insane...

At least on Windows and Linux, apart from the spacetime distortions (bug 956758), whenever an inspection popup opens, it immediately starts moving around in unexpected ways and towards unexpected places. The act of simply expanding/collapsing a property would cause the popup to shift weirdly.

This used to work properly.

Comment 1

[Victor Porof [:vporof][:vp]]

I I can't get to the bottom of this, I'll be seriously considering displaying the variables view inline, in the editor, instead of opening it in a popup. This might end up looking like a console.dir() in the webconsole.

What do you guys think about this? Would it be awful?

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I think that would be fine.

Comment 3

[Girish Sharma [:Optimizer]]

(In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> I think that would be fine.

Apart from looking funny and weird, that would be super slow as it will cause everything to shift down, causing a lot of reflows and stuff (due to how CM works)

I suggest using the cursor node as the anchor and having only the X offset while opening the popup. 
Introducing Y offset causes bad things to happen. Especially things never align when you have the devtools zoomed up or down.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: dbg-tooltip.patch

This might work. I'll play with it some more.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v2

This seems to be working reasonably well from what I've tested.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8357095 [details] [diff] [review]
v2

Review of attachment 8357095 [details] [diff] [review]:
-----------------------------------------------------------------

I still can't reproduce it locally, but the changes look fine to me.

::: browser/devtools/sourceeditor/editor.js
@@ +558,5 @@
> +    let mark = cm.markText(from, to, { replacedWith: span });
> +    return {
> +      anchor: span,
> +      clear: () => mark.clear()
> +    };

Just checking, but does mark.clear() discard replacedWith nodes automatically?

Comment 7

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #6)
> 
> Just checking, but does mark.clear() discard replacedWith nodes
> automatically?

Yup.

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/ce93163fa554

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ce93163fa554