957238 - HSTS weekly update on esr24 doesn't know that the build filename includes "esrpre"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/

INFO: Retrieving current version from hg...
--2014-01-04 03:02:38--  http://hg.mozilla.org/releases/mozilla-esr24/raw-file/default/browser/config/version.txt
Resolving hg.mozilla.org... 63.245.215.25
Connecting to hg.mozilla.org|63.245.215.25|:80... connected.
HTTP request sent, awaiting response... 200 Script output follows
Length: 13 [text/plain]
Saving to: “version.txt”

     0K                                                       100% 1.91M=0s

2014-01-04 03:02:39 (1.91 MB/s) - “version.txt” saved [13/13]

INFO: Downloading all the necessary pieces...
--2014-01-04 03:02:39--  http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/firefox-24.2.0.en-US.linux-x86_64.tar.bz2
Resolving stage.mozilla.org... 63.245.215.47
Connecting to stage.mozilla.org|63.245.215.47|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2014-01-04 03:02:39 ERROR 404: Not Found.

ERROR: wget exited with a non-zero exit code: 8

version.txt certainly seems to me to have the "esrpre" in it, do we then have some logic which assumes it should be stripped out?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Yes,  http://hg.mozilla.org/build/tools/file/default/scripts/hsts/update_hsts_preload_list.sh#l94:
 VERSION=`cat version.txt | sed 's/[^.0-9]*$//'`

coop may know why this is there.

Comment 2

[Phil Ringnalda (:philor)]

Ah, clarity dawns. Prior to 6.0, we had version numbers like 4.2a1pre, but the build filenames dropped the pre. That's been gone since April 2011, so we should be able to just drop it.

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Stop doing pattern matching on the version

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8358033 [details] [diff] [review]
Stop doing pattern matching on the version

Review of attachment 8358033 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/tools/rev/2a09721cfdc2