HSTS weekly update on esr24 doesn't know that the build filename includes "esrpre"

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: philor, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/

INFO: Retrieving current version from hg...
--2014-01-04 03:02:38--  http://hg.mozilla.org/releases/mozilla-esr24/raw-file/default/browser/config/version.txt
Resolving hg.mozilla.org... 63.245.215.25
Connecting to hg.mozilla.org|63.245.215.25|:80... connected.
HTTP request sent, awaiting response... 200 Script output follows
Length: 13 [text/plain]
Saving to: “version.txt”

     0K                                                       100% 1.91M=0s

2014-01-04 03:02:39 (1.91 MB/s) - “version.txt” saved [13/13]

INFO: Downloading all the necessary pieces...
--2014-01-04 03:02:39--  http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-esr24/firefox-24.2.0.en-US.linux-x86_64.tar.bz2
Resolving stage.mozilla.org... 63.245.215.47
Connecting to stage.mozilla.org|63.245.215.47|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2014-01-04 03:02:39 ERROR 404: Not Found.

ERROR: wget exited with a non-zero exit code: 8

version.txt certainly seems to me to have the "esrpre" in it, do we then have some logic which assumes it should be stripped out?
Yes,  http://hg.mozilla.org/build/tools/file/default/scripts/hsts/update_hsts_preload_list.sh#l94:
 VERSION=`cat version.txt | sed 's/[^.0-9]*$//'`

coop may know why this is there.
(Reporter)

Comment 2

4 years ago
Ah, clarity dawns. Prior to 6.0, we had version numbers like 4.2a1pre, but the build filenames dropped the pre. That's been gone since April 2011, so we should be able to just drop it.
(Assignee)

Comment 3

4 years ago
Created attachment 8358033 [details] [diff] [review]
Stop doing pattern matching on the version
Assignee: nobody → coop
Status: NEW → ASSIGNED
Attachment #8358033 - Flags: review?(nthomas)
Attachment #8358033 - Flags: review?(nthomas) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8358033 [details] [diff] [review]
Stop doing pattern matching on the version

Review of attachment 8358033 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/tools/rev/2a09721cfdc2
Attachment #8358033 - Flags: checked-in+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.