957279 - Notes+ app does not always remove old title during Renaming of a Notebook causing overlap

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Notes, defect)

Description

[Peter Bylenga [:PBylenga]]

Attachment: Notes+_Notebook_Title_Edit_Overlap.png

Description:
When editing a Notebook Title via Notebook view, the old title is not always removed causing the new text to overlap the old. This issue does not reproduce when changing the title of a Note via Note view.

Repro Steps:
1) Updated Buri to Build ID: 20140106004001
2) Use git to get the latest phase2 Notes+ app
3) Use App Manager to put on device
4) Launch Notes+ App from Everything.me screen
5) Create a new note and tap done.
6) Tap Notebook title to edit
7) Make changes to title and observe


Actual:
New changes overlap the original title

Expected:
Original title is replaced with the changes made

Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a43cb4b322d3
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Platform Version: 28.0a2
Firmware Version: 20131115

Notes:
Repro frequency: 4/5, 80%
See attached: screenshot

App built using:
https://github.com/mozilla-b2g/notes/tree/phase2
This issue reproduces on v1.2
Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/d552c08a72d0
Gaia: 8441587c3b352e052fee07665c21fd192540f19f
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: v1.2_20131115

Comment 1

[Yan Or]

Attachment: Pull request

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8358720 [details] [review]
Pull request

r+ for Matias

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/notes/commit/5d8a61166d41f576a0fd214967f9cc1928cff3d7

Comment 4

[Peter Bylenga [:PBylenga]]

I was able to verify this issue as Fixed in the following build with the latest version of Notes app:

v1.3 Environmental Variables:
Device: Buri v1.3 MOZ
BuildID: 20140410004002
Gaia: 62acb4b0e774b6709b8be400d849f807404bb21b
Gecko: 94baf6039462
Version: 28.0
Firmware Version: v1.2-device.cfg