Closed
Bug 957358
Opened 12 years ago
Closed 12 years ago
Restrict everything in Char16.h to C++
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
3.86 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8358367 -
Flags: review?(Pidgeot18)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8358367 [details] [diff] [review]
Patch (v1)
Review of attachment 8358367 [details] [diff] [review]:
-----------------------------------------------------------------
::: mfbt/Char16.h
@@ +160,5 @@
> * CPP manual for a more accurate and precise explanation.
> */
> #define MOZ_UTF16(s) MOZ_UTF16_HELPER(s)
>
> +#if (__cplusplus >= 201103L || defined(__GXX_EXPERIMENTAL_CXX0X__))
Get rid of this #ifdef altogether? All of our compilers should be in C++11 mode anyways.
Attachment #8358367 -
Flags: review?(Pidgeot18) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•