Closed Bug 957358 Opened 6 years ago Closed 6 years ago

Restrict everything in Char16.h to C++

Categories

(Core :: String, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: Ehsan, Assigned: Ehsan)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 958497
Attached patch Patch (v1)Splinter Review
Attachment #8358367 - Flags: review?(Pidgeot18)
Comment on attachment 8358367 [details] [diff] [review]
Patch (v1)

Review of attachment 8358367 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/Char16.h
@@ +160,5 @@
>   * CPP manual for a more accurate and precise explanation.
>   */
>  #define MOZ_UTF16(s) MOZ_UTF16_HELPER(s)
>  
> +#if (__cplusplus >= 201103L || defined(__GXX_EXPERIMENTAL_CXX0X__))

Get rid of this #ifdef altogether? All of our compilers should be in C++11 mode anyways.
Attachment #8358367 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/mozilla-central/rev/6a9730f94bae
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.