957395 - 40 character limit for a URL in the Fraud Report page is much too short

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

URLs can be of any length. Accepting hundreds if not low thousands of characters seems like a more reasonable limit. http://www.boutell.com/newfaq/misc/urllength.html

Comment 1

[ShanSM]

Hi,

Is it possible to get this assigned to me? Also what do you think the char. limit should be? Maybe like 2000? 

Thanks!

Comment 2

[Mike Alexis [:malexis]]

Hi ShanSM,
Welcome! I've assigned the bug over to you and cc'd Jon Petto who originally worked on the page. He and I can help get you set up to work on this.

Here is the documentation to get started working on Mozilla.org:

http://bedrock.readthedocs.org/en/latest/

Jon, any opinions on character length?

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Already had a pull request for this. https://github.com/mozilla/bedrock/pull/1594 should have updated the bug.

Comment 4

[Jonathan Petto [:jpetto]]

Welcome ShanSM!

After a quick look, many of the fraud report form fields should have a larger max_length value. The original author should be ashamed at this oversight. Oh, wait...that was me.

For the URL, I think a limit of 2000 is perfect.

The other big one we should update is input_email, which is currently set to 80 characters. It looks like the maximum length of an email address is 254 characters (http://stackoverflow.com/questions/386294/what-is-the-maximum-length-of-a-valid-email-address), so I'd say go with that.

input_specific_product and input_attachment_description are both a bit short as well. They could both be bumped up to 254, though you could make a case for input_attachment_description being even longer.

Feel free to ping me if you have any questions or need any help getting bedrock up and running. :)

Comment 5

[Jonathan Petto [:jpetto]]

Kevin - 

Do you think you can easily update your pull request to address the updates outlined in comment 4? If you're busy, perhaps we can pass along to ShanSM?

Thanks!

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Sure I can pass it along. Have a bit of Firefox 27 beta stuff to deal with.

Comment 7

[Jonathan Petto [:jpetto]]

Hey ShanSM - Looks like this one is all yours. Let me know if you have any questions or difficulty getting bedrock running. If you need real time help, hop on the #www channel on IRC (https://wiki.mozilla.org/IRC).

Also, please comment if you're no longer able to take this on.

Thanks!

Comment 8

[Jonathan Petto [:jpetto]]

Hi ShanSM - Just wanted to check in on this bug. How are things going? Anything I can help with?

Comment 9

[Jonathan Sundqvist]

I presume this is still assigned to ShanSM?

Comment 10

[Jonathan Petto [:jpetto]]

(In reply to Jonathan Sundqvist from comment #9)
> I presume this is still assigned to ShanSM?

Hey Jonathan - 

It looks like ShanSM got busy with other things. Would you like to take this on?

Comment 11

[Jonathan Sundqvist]

Yes, I will take this one. 
I made a pull request on it here: https://github.com/mozilla/bedrock/pull/1650

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f4243fa7c706b7ab311ea2486c4688fc0b401306
Fix Bug 957395 - 40 character limit for a URL in the Fraud Report page is much too short

https://github.com/mozilla/bedrock/commit/6c44a1a3a0d1e57d62cd733d59ff748cbc9f78d9
Merge pull request #1650 from jonathan-s/bugfix

Fix Bug 957395 - 40 character limit for a URL in the Fraud Report

Comment 13

[raymond [:retornam] (inactive)]

fixed on stage https://www.allizom.org/en-US/legal/fraud-report/

Comment 14

[raymond [:retornam] (inactive)]

verified fixed on https://www.mozilla.org/en-US/legal/fraud-report/