957427 - Expose an nsILoadContext shim in nsIFrameLoader

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: cpp-load-context

There's a lot of code that wants to use nsILoadContext to get information about private browsing. For example, we need one in bug 691614. Also, right now we create an nsILoadContext dynamically in the networking code so that it can be used in a channel. I think it would be better to have a single load context in the parent for each remote tab. That way everyone can at least use the same one.

Right now the patch bases the private browsing flag on the window. But if we allow per-tab private browsing, it would be easy to change this.

I have mixed feelings about this patch. nsILoadContext is a pretty gross interface, so I don't like exposing it more than we already do. But the alternative is to change a ton of code that relies on it to use something else, and I don't want to do that right now.

Comment 1

[(no longer active)]

Comment on attachment 8356915 [details] [diff] [review]
cpp-load-context

Review of attachment 8356915 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/nsIFrameLoader.idl
@@ +130,5 @@
> +   * Get an nsILoadContext for the top-level docshell. For remote
> +   * frames, a shim is returned that contains private browsing and app
> +   * information.
> +   */
> +  readonly attribute nsILoadContext loadContext;

Please rev the uuid.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/354f1ca641c4

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/354f1ca641c4