95743 - submitting changes with login unsets "roles" checkboxes

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Submit a change while not logged in, then log in to an account with access to at
least one bug group.  The "roles" checkboxes that govern whether or not the
reporter, assignee, qa contact, and cc list can always see the bug get unset.

This is because process_bug assumes the user saw those checkboxes and unset them
if the user has access to a bug group, but the user would not have seen those
checkboxes if they were not logged in when initially viewing the bug.

Comment 1

[Dave Miller [:justdave]]

b.m.o shakedown.

FYI, this affects group bits, too, not just the roles checkboxes.  We haven't
seen it happen yet, but examination of the relevant code indicates that the
group checkboxes will fall victim to this same problem.

Comment 2

[Dave Miller [:justdave]]

CCing some people that have done work with the group / checkbox code recently

Comment 3

[Dave Miller [:justdave]]

CCing some people that have done work with the group / checkbox code recently

Comment 4

[Andreas Franke (gone)]

I've seen this happen at bug 68045.

[e-mail] changed:

                           What    |Removed                     |Added
               
----------------------------------------------------------------------------
                assignee_accessible|1                           |0
                  cclist_accessible|1                           |0
                qacontact_accessibl|1                           |0
                                  e|                            |
                reporter_accessible|1                           |0

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: only shows roles checkboxes if bug in group (and thus user already logged in)

Comment 6

[Myk Melez [:myk] [@mykmelez]]

This patch also removes some debugging code I forgot to remove in the patch for
bug 66235.

Comment 7

[Dave Miller [:justdave]]

r= justdave
checked in.

Comment 8

[Dave Miller [:justdave]]

Moving to Bugzilla product