957506 - [fugu][buri][contact] cannot export contact with no family name to SD Card or Bluetooth

Status: RESOLVED DUPLICATE of bug 965168

(Firefox OS Graveyard :: General, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

Environment:
--------------------------
V1.3
Gaia ff5f06dd321f7d2bf4a5b311ded2c56e865d4f83
Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/71ad7ff30010
BuildID 20140107004001
Version 28.0a2
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Reproduce Steps:
--------------------------
1. Launch Contact and Create a contact
2. On Contacts page, Tap on Setting icon on the top right
3. Select "Export Contacts"
4. Select "Memory card" or "Bluetooth"
5. Select some contact and tap on "Export"
   --> Exporting cannot finish. The page keeps showing "Export to SD Card".

Export to SIM card works.

Comment 1

[sam.hua]

Hi Pcheng
our SQA said it is fixed,could u verify it?
Thanks!

Comment 2

[Peipei Cheng (needinfo if you need my action)]

(In reply to sam.hua from comment #1)
> Hi Pcheng
> our SQA said it is fixed,could u verify it?
> Thanks!

I can still reproduce it on latest buri v1.3 build.

Gaia      1f029aa4c924d6c59fd7e8c6d9786a7370755d49                         
Gecko     http://hg.mozilla.org/releases/mozilla-aurora/rev/c42fd6b6d1fc   
BuildID   20140112004002                                                   
Version   28.0a2

Comment 3

[Peipei Cheng (needinfo if you need my action)]

Attachment: 957506.log

attached is the adb log. test start at 01-13 13:53:31.519

The contact I use has no family name.

here is the error message
E/GeckoConsole( 1462): [JavaScript Error: "TypeError: contact.familyName is null" {file: "app://communications.gaiamobile.org/contacts/js/export/sd.js" line: 40}]

Comment 4

[Peipei Cheng (needinfo if you need my action)]

Reproduce Steps:
--------------------------
1. Launch Contact and Create a contact without family name. (Important!!!)
2. On Contacts page, Tap on Setting icon on the top right
3. Select "Export Contacts"
4. Select "Memory card" or "Bluetooth"
5. Select some contact and tap on "Export"
   --> Exporting cannot finish. The page keeps showing "Export to SD Card".

Comment 5

[sam.hua]

block the sanity test

Comment 6

[Neeraj]

Attachment: Patch for this bug.

Here is the proposed patch(https://github.com/mozilla-b2g/gaia/pull/15296). Please review it and let me know if it works.

Regards,

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8359756 [details] [review]
Patch for this bug.

This is a good catch and definitely needs to be fixed!  I commented in the github PR, though, that maybe we can simplify the nest if-statement logic a bit.

Also, I'd like to see a unit test to prevent this from regressing again in the future.  Can you add a test case and then re-flag me for review?

Thanks!