957641 - numbers in place of "signout"

Status: RESOLVED FIXED

(Webmaker Graveyard :: General, defect)

Description

[Tim [:pollti]]

Attachment: mozillaWebmaker (error on top right)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

I logged in to Webmaker by Personas.


Actual results:

I see numbers in place of "signout"


Expected results:

It should look normal ;-)

Comment 1

[Tim [:pollti]]

Attachment: mozillaWebmakerErrorZoom

Comment 2

[Pomax]

This looks like the image hash for the gravatar image for when you log in, can you reproduce this reliably? (e.g. does it happen every time? If so, would you be able to check the HTML structure for that to see whether it's in an <img> or is plain text?)

Comment 3

[Tim [:pollti]]

Attachment: img tag for bug

Yes your right! It's an <img> and links to the gravator as in the picture.
How can I change that?

Comment 4

[Tim [:pollti]]

The problem doesn't exist when I add a picture at gravatar.com for the e-mail-adress I use there.

Comment 5

[Pomax]

Attachment: Capture.PNG

hm, when there is no image available, it should fall back to a default avatar image. When I load up webmaker (I don't use gravatar), the img element contains this:

<img src="https://secure.gravatar.com/avatar/LARGEHEXADEXIMALSTRING?s=26&amp;d=https%3A%2F%2Fstuff.webmaker.org%2Favatars%2Fwebmaker-avatar-44x44.png" alt="SAMELARGEHEXADEXIMALSTRING">

When you load up the site and login, do you get a similar image element, or are there differences in the URL it's trying to load? If the image 404s, that would explain the "alt" text showing up.

Comment 6

[Tim [:pollti]]

When I delete my Gravatar-image now I also see the image you just uploaded. Sorry, it's unreproducible for me now.

Comment 7

[David Humphrey (:humph)]

Thanks Tim, I'm going to close this.  If we see it again, let's get a new bug.

Comment 8

[Tim [:pollti]]

I have the problem again now.

Comment 9

[Pomax]

are the steps to reproduce the same?

ccing jbuck and cade since new auth should have fixed it.

Comment 10

[Tim [:pollti]]

Yes, the steps are the same. It doesn't happen every time and when it happens, they normally disappear after one second (but not always).

Comment 11

[Jon Buckley [:jbuck]]

Looks like this can happen when the image fails to load and it displays the alt attribute instead of the image src. Pomax suggested making the alt tag a blank string, which should do the trick!

Comment 12

[Tim [:pollti]]

Yes, I think that would be better ;)

Comment 13

[Pomax]

I already did this for the login update for Thimble, I'll effect that change for the other apps as well.

Comment 14

[Pomax]

Attachment: https://github.com/mozilla/webmaker.org/pull/628

fix for webmaker.org

Comment 15

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/51b415bec7ddb41fa6272300726a960cf9d13ac0
Merge pull request #628 from Pomax/bug957641

empty alt text