Closed Bug 957665 Opened 6 years ago Closed 6 years ago

Add telemetry to measure how many people have OCSP enabled

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla29
Tracking Status
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Since these options are exposed in the options UI, and because I've seen a lot of advice about disabling OCSP to work around OCSP issues (especially "Unknown" errors), I think it may be the case that a lot of users have disabled OCSP fetching already. Let's measure that. This would be a useful input in the decisions regarding what to do about OCSP fetching long-term.
Attachment #8357200 - Flags: review?(dkeeler)
Comment on attachment 8357200 [details] [diff] [review]
ocsp-pref-telemetry.patch

Review of attachment 8357200 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: security/manager/ssl/src/nsNSSComponent.cpp
@@ +1009,5 @@
> +
> +  // We measure the setting of the pref at startup only to minimize noise by
> +  // addons that may muck with the settings, though it probably doesn't matter.
> +  if (isInitialSetting) {
> +    Telemetry::Accumulate(Telemetry::CERT_OCSP_ENABLED, ocspEnabled);

It's sort-of a bummer that ocspEnabled is an int, but we're consistent with how we use it, so treating an int as a bool here should be fine (I just wanted to specifically mention this).
Attachment #8357200 - Flags: review?(dkeeler) → review+
Comment on attachment 8357200 [details] [diff] [review]
ocsp-pref-telemetry.patch

Review of attachment 8357200 [details] [diff] [review]:
-----------------------------------------------------------------

* No string changes.
* Very low risk, as this is just adding telemetry.
* Landed on mozilla-inbound on Saturday night.
* No need for QA.

This telemetry is important for us to make decisions about OCSP in the near future so it is important to uplift it to Fx27 to get release-channel level data for Firefox 27.

(The questionnaire that normally pops up when we request uplift doesn't seem to be working right now.)
Attachment #8357200 - Flags: approval-mozilla-beta?
Attachment #8357200 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/38807790e001
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8357200 - Flags: approval-mozilla-beta?
Attachment #8357200 - Flags: approval-mozilla-beta+
Attachment #8357200 - Flags: approval-mozilla-aurora?
Attachment #8357200 - Flags: approval-mozilla-aurora+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.