957707 - HTTP cache v2: merge management thread and IO thread, new MANAGEMENT level

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

During shutdown we race IO thread and management thread (memory purging).  There is a risk of static vars mt access and keeping stuff alive after IO manager is shutdown.  Also, since the memory pool management is a very low priority stuff to do and we now have two threads regarding the new cache, I think it's an unnecessary luxury.

We only must prevent nearly empty (no-op) loops when the pool is large and over the limit but there is by accident nothing or very little to purge.  Triggering purge only when over a limit+threshold might do the trick.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: wip1 - backup

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8359784 [details] [diff] [review]
wip1 - backup

Causes Assertion failure: progress <= progressMax (unexpected progress values), at ../../../../netwerk/protocol/http/nsHttpChannel.cpp:5413
TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_bug495300.html

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: wip2

https://tbpl.mozilla.org/?tree=Try&rev=29d9580d7a53

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: wip2.1 [unstable]

https://tbpl.mozilla.org/?tree=Try&rev=37d8fbc8bf73

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 8361365 [details] [diff] [review]
wip2.1 [unstable]

Still causes Assertion failure: progress <= progressMax 
https://tbpl.mozilla.org/php/getParsedLog.php?id=33167617&tree=Try

Comment 7

[Honza Bambas (:mayhemer)]

More runs (wip2.1):

gum=https://hg.mozilla.org/projects/gum/rev/5b6518ffeafe

https://tbpl.mozilla.org/?tree=Try&rev=10ec2b78fced (right over gum)
https://tbpl.mozilla.org/?tree=Try&rev=4626f299bb52 (index+gum)

Comment 8

[Honza Bambas (:mayhemer)]

Index has no influence:
https://tbpl.mozilla.org/php/getParsedLog.php?id=33179973&tree=Try

Comment 9

[Honza Bambas (:mayhemer)]

Attachment: v1 (stable)

https://tbpl.mozilla.org/?tree=Try&rev=7c1d1ca3f804 (with bug 958311)

Comment 10

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/mozilla-central/rev/8624d24dbe67