957717 - Bad comment syntax highlighting at preprocessor directives

Status: RESOLVED WONTFIX

(Webtools Graveyard :: DXR, defect)

Description

[:ytx]

Comment symbols ( /* , */ ) in strings in preprocessor directives get highlighted as comments, despite being in a string.
Even worse, if there is no comment end symbol, the whole syntax highlighting is corrupted until it finds a comment end symbol later in the code. 

Examples:
http://dxr.mozilla.org/mozilla-central/source/storage/public/mozStorageHelper.h#179
http://dxr.mozilla.org/mozilla-central/source/netwerk/mime/nsMimeTypes.h#19 (corrupts all the way down to line 149)
http://dxr.mozilla.org/mozilla-central/source/netwerk/build/nsNetModule.cpp#400 (also corrupts the whole section, this one also shows that it corrupts anything, not only preprocessor directives)

http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/JARSignatureVerification.cpp#255
http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsJAR.cpp#479
(These two are quite interesting, they both have the same line that is causing the problem, but only the former shows corruption, the latter isn't corrupted because there simply is no end comment symbol below it)

Comment 1

[Erik Rose [:erik][:erikrose]]

Confirmed. We actually delegate the parsing for our syntax highlighting to Pygments, so it would be interesting to know if there is a corresponding bug filed there.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.