Closed Bug 957780 Opened 7 years ago Closed 7 years ago

Android fails to build with --disable-webrtc

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(1 file)

Building for android with --disable-webrtc results in the following error:

java -jar /home/mshal/adt-bundle-linux-x86_64-20131030/sdk/tools/proguard/lib/proguard.jar @/home/mshal/mozilla-central-git/mobile/android/config/proguard.cfg -optimizationpasses 6 -injars gecko-browser.jar:gecko-mozglue.jar:gecko-util.jar:sync-thirdparty.jar:websockets.jar: -outjars jars-proguarded -libraryjars /home/mshal/adt-bundle-linux-x86_64-20131030/sdk/platforms/android-16/android.jar:/home/mshal/adt-bundle-linux-x86_64-20131030/sdk/extras/android/support/v4/android-support-v4.jar
proguard.ParseException: Expecting jar or directory name before '-outjars' in argument number 6
	at proguard.ConfigurationParser.readNextWord(ConfigurationParser.java:1133)
	at proguard.ConfigurationParser.parseClassPathArgument(ConfigurationParser.java:249)
	at proguard.ConfigurationParser.parse(ConfigurationParser.java:128)
	at proguard.ProGuard.main(ProGuard.java:484)

This happens because of the trailing ':' in the -injars argument, which appears because of how ALL_JARS is defined in mobile/android/base/Makefile.in:

ALL_JARS = \
  gecko-browser.jar \
  gecko-mozglue.jar \
  gecko-util.jar \
  sync-thirdparty.jar \
  websockets.jar \
  $(NULL)

ifdef MOZ_WEBRTC
ALL_JARS += webrtc.jar
endif

Without MOZ_WEBRTC, ALL_JARS is '... websockets.jar ', and then spaces are replaced with colons resulting in '...:websockets.jar:'
Using $(strip) seems easiest.
Assignee: nobody → mshal
Attachment #8357382 - Flags: review?(mh+mozilla)
Attachment #8357382 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f6e3cd08cb6e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.