iframe sandbox test (*_c_if2.html) should fail when allow-scripts is not set

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: deian, Assigned: deian)

Tracking

Trunk
mozilla29
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
The ok function in file_iframe_sandbox_c_if2.html uses an undefined variable 'message' vs. the correct 'desc'
Assignee

Comment 1

6 years ago
Attachment #8357441 - Flags: review?(ian.melven)
Comment on attachment 8357441 [details] [diff] [review]
Bug-957821.patch

Review of attachment 8357441 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but I'm not a /content peer

Kyle, can you see if this is alright or redirect to another content peer ? Thanks !
Attachment #8357441 - Flags: review?(khuey)
Attachment #8357441 - Flags: review?(ian.melven)
Attachment #8357441 - Flags: review+
Thanks Kyle ! 

Deian, probably worth doing a try push on at least one platform here and then this should be ready to land.
Assignee

Comment 4

6 years ago
Thanks both!

Try is good:
https://tbpl.mozilla.org/?tree=Try&rev=8642844e15da
Assignee

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d95b51c157ec
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.