Closed
Bug 957821
Opened 10 years ago
Closed 10 years ago
iframe sandbox test (*_c_if2.html) should fail when allow-scripts is not set
Categories
(Core :: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: deian, Assigned: deian)
Details
Attachments
(1 file)
|
915 bytes,
patch
|
imelven
:
review+
khuey
:
review+
|
Details | Diff | Splinter Review |
The ok function in file_iframe_sandbox_c_if2.html uses an undefined variable 'message' vs. the correct 'desc'
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8357441 -
Flags: review?(ian.melven)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8357441 [details] [diff] [review] Bug-957821.patch Review of attachment 8357441 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me but I'm not a /content peer Kyle, can you see if this is alright or redirect to another content peer ? Thanks !
Attachment #8357441 -
Flags: review?(khuey)
Attachment #8357441 -
Flags: review?(ian.melven)
Attachment #8357441 -
Flags: review+
Attachment #8357441 -
Flags: review?(khuey) → review+
|
|
||
Comment 3•10 years ago
|
||
Thanks Kyle ! Deian, probably worth doing a try push on at least one platform here and then this should be ready to land.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks both! Try is good: https://tbpl.mozilla.org/?tree=Try&rev=8642844e15da
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d95b51c157ec
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d95b51c157ec
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•