Synchronize mach with Git repository

RESOLVED FIXED in mozilla29

Status

Firefox Build System
Mach Core
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla29

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
There are a few changes in mach's Git repository that need to get imported into m-c. I'm pretty sure I committed these upstream without review. Would like to get review now and would like to get the repositories in sync.

FWIW, I plan to nuke the Git mirror and just develop mach in tree, just like we're doing with mozbase now. IMO all that people really care about is packages available on PyPI, and I can do that anywhere setup.py is.
(Assignee)

Comment 1

4 years ago
Created attachment 8357469 [details] [diff] [review]
Synchronize mach with upstream repository

The test changes and setup.py are NPOTB. base.py and main.py
added a new feature to declare global arguments.
Attachment #8357469 - Flags: review?(ahalberstadt)
(Assignee)

Updated

4 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment on attachment 8357469 [details] [diff] [review]
Synchronize mach with upstream repository

Review of attachment 8357469 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, might want to add some sort of documentation about how to use the global_argument to the readme and/or mdn page though.
Attachment #8357469 - Flags: review?(ahalberstadt) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/262188b2629e

with docs updates.
Flags: in-testsuite-
(Assignee)

Updated

4 years ago
Blocks: 909522
https://hg.mozilla.org/mozilla-central/rev/262188b2629e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.