957857 - Preloading contacts in a SIM customization does not work anymore

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jason Smith [:jsmith]]

Build - 1/8/2014 Buri 1.3

STR

1. Follow the steps here - https://wiki.mozilla.org/B2G/QA/Customizations#Build_Setup to setup your customized build with an AT&T US SIM
2. After completing the FTE, launch the contacts app

Expected

There should be four contacts present - test 1, test 2, 310410 person, and Inf 310410.

Actual

There is only two contacts present - test 1, test 2. This implies that the SIM customized contacts failed to be preloaded.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ regression

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

hi Yuren, wonder if you have some insight into this? Thanks

Comment 3

[Reuben Morais [:reuben]]

Is there anything about contacts in the logcat?

Comment 4

[Albert [:albert]]

I think this bug and 957866 are caused by bug 952922, I will review build dependencies.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

This is a part of customization mechanism of variant.json. Albert, could you help on this issue?

Comment 6

[Albert [:albert]]

From logcat:

E/GeckoConsole( 1401): [JavaScript Error: "TypeError: 'type' member of ContactField can't be converted to a sequence." {file: "app://communications.gaiamobile.org/ftu/js/customizers/default_contacts_customizer.js" line: 7}]

Error when creating contact -> var contact = new mozContact(contacts[i]);


The format of attus_contacts.json is wrong, the attribute 'type' should be an array instead of string.
Modifying "type": "Other" by "type": ["Other"] fix the problem.

Comment 7

[Albert [:albert]]

Can you modify https://github.com/mozilla/qa-testcase-data/blob/gh-pages/customization/reference/attus/attus_contacts.json and https://github.com/mozilla/qa-testcase-data/blob/gh-pages/customization/reference/tmobileus/tmobileus_contacts.json ?

Comment 8

[Jason Smith [:jsmith]]

(In reply to Albert [:albert] from comment #6)
> From logcat:
> 
> E/GeckoConsole( 1401): [JavaScript Error: "TypeError: 'type' member of
> ContactField can't be converted to a sequence." {file:
> "app://communications.gaiamobile.org/ftu/js/customizers/
> default_contacts_customizer.js" line: 7}]
> 
> Error when creating contact -> var contact = new mozContact(contacts[i]);
> 
> 
> The format of attus_contacts.json is wrong, the attribute 'type' should be
> an array instead of string.
> Modifying "type": "Other" by "type": ["Other"] fix the problem.

That's not right. This is exact format worked fine on 1.2, so this is a regression in format parsing on 1.3.

Comment 9

[Albert [:albert]]

(In reply to Jason Smith [:jsmith] from comment #8)
> (In reply to Albert [:albert] from comment #6)
> > From logcat:
> > 
> > E/GeckoConsole( 1401): [JavaScript Error: "TypeError: 'type' member of
> > ContactField can't be converted to a sequence." {file:
> > "app://communications.gaiamobile.org/ftu/js/customizers/
> > default_contacts_customizer.js" line: 7}]
> > 
> > Error when creating contact -> var contact = new mozContact(contacts[i]);
> > 
> > 
> > The format of attus_contacts.json is wrong, the attribute 'type' should be
> > an array instead of string.
> > Modifying "type": "Other" by "type": ["Other"] fix the problem.
> 
> That's not right. This is exact format worked fine on 1.2, so this is a
> regression in format parsing on 1.3.

Anyway, is not a problem of single variant, the problem is with contacts API.

Comment 10

[Jason Smith [:jsmith]]

Reuben - Was the syntax change in the Contacts API intentional above?

Comment 11

[Reuben Morais [:reuben]]

Yes. 'type' was always an array, but we only started enforcing it on 1.3 :(

Comment 12

[Jason Smith [:jsmith]]

Okay - that makes this invalid then. I just patched the customization to use an array instead.