Closed Bug 957881 Opened 8 years ago Closed 8 years ago

Get rid of recommended addons code

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(1 file)

We don't have a recommended add-ons section on about:home anymore, so we should get rid of the code associated with it.

It doesn't even look like we've used the recommended-addons.json that's bundled in the app dir for a while.

And this code makes it look like we're doing a network request now whose result is never even used for anything:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/AddonUpdateService.js#117
If we no longer display recommended add-ons, then let's remove:
* The bundled file
* The code to load the file
* The code to download the JSON and make the file
* Any other related code :)
This sounds fun, I want to do it.

I wonder if we should add some sort of migration code to delete the file from existing profiles. On the one hand, that would give users back a little space, but on the other hand it might not be worth the effort, since it's a pretty small file. I'm leaning towards just leaving existing profiles alone.
Assignee: nobody → margaret.leibovic
Attached patch patchSplinter Review
Attachment #8358658 - Flags: review?(bnicholson)
Comment on attachment 8358658 [details] [diff] [review]
patch

LGTM. We can always purge recommended-addons.json from the profile later if we decide we don't want it.
Attachment #8358658 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/5ae12ca85cdc
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.