957884 - textured3d11.cpp(36) : warning C4715: 'mozilla::layers::SurfaceFormatToDXGIFormat' : not all control paths return a value

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning, found when trying bug 957784:
{
gfx\layers\d3d11\textured3d11.cpp(36) : warning C4715: 'mozilla::layers::SurfaceFormatToDXGIFormat' : not all control paths return a value
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1: return DXGI_FORMAT_UNKNOWN

This just makes us return a bogus UNKNOWN value (which is listed at the start of the enum, according to http://msdn.microsoft.com/en-us/library/windows/desktop/bb173059%28v=vs.85%29.aspx , which I ran across from searching the web for the enum typename.)

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc2a2e09f121

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc2a2e09f121