95789 - wrong default domain after selecting different mail account

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Bob Lord]

Build: 2001 08 15 04
WinME

I have two mail accounts.  When I compose a new mail message, bug 79053 often
causes the client to select the wrong mail account.  This bug causes the sig and
the From header to be incorrectly set to [e-mail] rather than
[e-mail].

I change the mail account from [e-mail] to [e-mail] by clicking on
the From pop-up menu.  (This action triggers bug 95727)

Expected behavior:
When I add recipient email addresses, the mail compose window should assume I
want to auto-complete addresses under my [e-mail] profile.  That means
unspecified domains should default to "@netscape.com" and should also use the
Netscape LDAP server for type-down addressing.

Observed behavior:
The client assumes a "@well.com" suffix and does not use the Netscape LDAP server.

When the client correctly selects the [e-mail] mail account, things
work as expected.

Comment 1

[Bob Lord]

Attachment: snapshot of confused mail account selection

Comment 2

[Sheela Ravindran]

Might be a dup of one of the bugs you have

Comment 3

[Jean-Francois Ducarroz]

This is stiff a problem using a recent build. We have code to switch the default
domain when you change identity but that seems to be broken. Reassign to varada...

Comment 4

[varada]

Attachment: Patch V1

Regression was caused by moving the code that changed the domain when identity
changed.

Comment 5

[Jean-Francois Ducarroz]

Comment on attachment 94683 [details] [diff] [review]
Patch V1

r=ducarroz

Comment 6

[David :Bienvenu]

Comment on attachment 94683 [details] [diff] [review]
Patch V1

is this cloned code? if so, could we have a helper routine?

Comment 7

[varada]

Attachment: Patch V1.1

Moved some common code to another function.

Comment 8

[David :Bienvenu]

any particular reason you didn't add these two line to the helper routine?

+          if (!gAutocompleteSession)
+            gAutocompleteSession =
Components.classes["@mozilla.org/autocompleteSession;1?type=addrbook"].getService(Components.interfaces.nsIAbAutoCompleteSession);

Comment 9

[varada]

The two places that we use this are when we change the identity and when we
input in the addressing widget. In the former case (i.e. this bug) we need to
force the domain name check each time whereas in the latter we dont need to do
it if the gAutoCompleteSession already exists. 

Comment 10

[David :Bienvenu]

if I understand you correctly, then what you could have done is, in the bug
case, nulled out gAutoCompleteSession, and then called the helper routine, which
would look something like this:

function setupAutoComplete()
{
          if (!gAutocompleteSession)
            gAutocompleteSession =
Components.classes["@mozilla.org/autocompleteSession;1?type=addrbook"].getService(Components.interfaces.nsIAbAutoCompleteSession);
  if (gAutocompleteSession)
  {
  var emailAddr = gCurrentIdentity.email;
  var start = emailAddr.lastIndexOf("@");
  gAutocompleteSession.defaultDomain = emailAddr.slice(start + 1,   
emailAddr.length);
}

but I'll leave that up to you.

Comment 11

[David :Bienvenu]

Comment on attachment 96072 [details] [diff] [review]
Patch V1.1

sr=bienvenu

Comment 12

[varada]

The reason I didnt do that was because when the setupAutoComplete is called from
oninput in the addressing widget it is better to return if the
gAutocompleteSession already exists. If I nulled it and did the processing again
it would mean that much increase for each input in the addressing widget.

Comment 13

[varada]

Marking Fixed.

Comment 14

[Ninoschka Baca]

Buffy Trunk build 2002-10-29: WinMe, Linux 8, Mac 10.1.3
Verified Fixed.