957907 - Apps showing as unavailable

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[Andy McKay]

1. Open up stage marketplace on a b2g phone
2. Pick a region with some apps in it, eg: Spain
3. Search for :paid

Expected:

Can purchase an app

Actual:

Everything shows as unavailable. Clicking on the app on going to details shows the same.

Making a P2 because this blocks testing on stage of paid apps.

Comment 1

[Mathieu Pillard [:mat]]

Something wrong with the search API / ElasticSearch it looks like:

% curl https://marketplace.allizom.org/api/v1/apps/search/\?q\=pricetier6-1
[...]
     "price_locale" : null,
     "price" : null,
[...]

% curl https://marketplace.allizom.org/api/v1/apps/app/pricetier6-1/
[...]
   "price_locale" : "$2.99",
   "price" : "2.99",
[...

Comment 2

[krupa raj[:krupa]]

We lost a day of testing in Hungary over this. Making this a P1

Comment 3

[Wil Clouser [:clouserw]]

Rob and Mat were both working on this.  Whoever gets to it first can keep it. :)  I think Mat is asleep so -> rob.

Comment 4

[Rob Hudson [:robhudson]]

This commit changed it:
https://github.com/mozilla/zamboni/commit/62354cc609e477f78a591f4f3f34fa191c800505

Prior to this we passed the `region`, the integer, into es_app_to_dict which was used for the price lookups.

After this commit the passed in region is no longer used and the region is pulled from the GET parameter as the region slug.

Passing the region slug to the price lookups is essentially what broke this, as they now return `None`.

Since no other code passes in the region ID except the search calls I'm going to remove this parameter from this method. The region will be set from the GET param or fall back to the region set in the middleware and pulled via `get_region()`. The GET param override is useful from the collections tool.

The inconsistency between some calls wanting a region slug and others wanting a region ID is unfortunate.

PR coming soon.

Comment 5

[Rob Hudson [:robhudson]]

PR: https://github.com/mozilla/zamboni/pull/1612

Comment 6

[Rob Hudson [:robhudson]]

Merged: https://github.com/mozilla/zamboni/commit/57ef65f 

This will need to be pushed to stage for testing.

Comment 7

[Iulian Timis]

Verified as fixed in https://marketplace.allizom.org/ on FF29 (Android).
Attaching postfix screenshot.
Closing bug.

Comment 8

[Iulian Timis]

Attachment: postfix paid apps android.png