957921 - MOZ_Assert: Assertion failure: mOpened, at AsmJSCache.cpp:1032

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gregor Wagner [:gwagner]]

Seen during mochitests on b2g debug emulator builds:

https://tbpl.mozilla.org/php/getParsedLog.php?id=32730519&tree=Pine&full=1

Comment 1

[Luke Wagner [:luke]]

Lemme think about this in the morning; this might just be an overzealous assert.

Comment 2

[Luke Wagner [:luke]]

Ah hah, I see it: bug 944821 added a new child/parent roundtrip between the parent and child:
  parent -OnOpenMetadataForRead-> child -SelectCacheFileToRead-> parent
if the child fails to FindHashMatch in RecvOnOpenMetadataForRead, then it will Send__delete__ which causes the parent to Recv__delete__ when the cache file has not yet been opened, hence the assert.

Comment 3

[Luke Wagner [:luke]]

Attachment: fix-open-bug

Given the new interleaving described above, the fix is just to generalize Recv__delete__ to be more like ActorDestroy which can happen at any time.

I was able to repro the assert on desktop FF with browser.tabs.remote = true on http://people.mozilla.org/~lwagner/test-caching.html and verify that this patch fixes the assert.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8357603 [details] [diff] [review]
fix-open-bug

Review of attachment 8357603 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 5

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fcc5b6e4f23

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4fcc5b6e4f23