Closed
Bug 957930
Opened 12 years ago
Closed 12 years ago
[Search] Old results should not display when opening the search app
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Firefox OS Graveyard
Gaia::Search
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
Attachments
(1 file)
Currently results remain after closing the search application. They should go away.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Summary: [Search] Results should clear after closing the search app → [Search] Old results should not display when opening the search app
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 8357614 [details] [review]
Github pull request
Dale or Ben - Would one of you guys have cycles to review this?
It's not perfect yet, but it does the job. The one issue is that there can potentially be old results if they are slow. To fully solve this we need some abort mechanisms in place. Unfortunately we should wait for the E.me guys to finish up the partner API work to implement these abort mechanisms. I would like to land this as-is for now though.
Attachment #8357614 -
Flags: review?(dale)
Attachment #8357614 -
Flags: review?(bfrancis)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8357614 [details] [review]
Github pull request
Just one concern about the way that any method could be called based on a string sent from another app.
Attachment #8357614 -
Flags: review?(bfrancis) → review-
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 8357614 [details] [review]
Github pull request
Ben - Thanks for the review. I've changed it to actually check for existance now. Let me know if you think anything else needs to be updated.
Attachment #8357614 -
Flags: review- → review?(bfrancis)
|
|
||
Comment 5•12 years ago
|
||
I commented on GitHub
|
|
||
Updated•12 years ago
|
No longer blocks: rocketbar-search-mvp
Component: Gaia → Gaia::Search
|
||
Comment 6•12 years ago
|
||
Comment on attachment 8357614 [details] [review]
Github pull request
Looks good by me
Attachment #8357614 -
Flags: review?(dale) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Comment on attachment 8357614 [details] [review]
Github pull request
Thanks for the reviews guys. Ben - I've added guarding of the event, and I think it should suffice for now. We can certainly do more to enumerate the events if we want, but I don't see a particular need because the message is guarded by the manifest rules. I will happily review a pull request if this is of concern though.
Attachment #8357614 -
Flags: review?(bfrancis)
|
|
Assignee | |
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•