[Search] Old results should not display when opening the search app

RESOLVED FIXED

Status

Firefox OS
Gaia::Search
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
Currently results remain after closing the search application. They should go away.
(Assignee)

Comment 1

4 years ago
Created attachment 8357614 [details] [review]
Github pull request
(Assignee)

Updated

4 years ago
Summary: [Search] Results should clear after closing the search app → [Search] Old results should not display when opening the search app
(Assignee)

Comment 2

4 years ago
Comment on attachment 8357614 [details] [review]
Github pull request

Dale or Ben - Would one of you guys have cycles to review this? 

It's not perfect yet, but it does the job. The one issue is that there can potentially be old results if they are slow. To fully solve this we need some abort mechanisms in place. Unfortunately we should wait for the E.me guys to finish up the partner API work to implement these abort mechanisms. I would like to land this as-is for now though.
Attachment #8357614 - Flags: review?(dale)
Attachment #8357614 - Flags: review?(bfrancis)
Comment on attachment 8357614 [details] [review]
Github pull request

Just one concern about the way that any method could be called based on a string sent from another app.
Attachment #8357614 - Flags: review?(bfrancis) → review-
(Assignee)

Comment 4

4 years ago
Comment on attachment 8357614 [details] [review]
Github pull request

Ben - Thanks for the review. I've changed it to actually check for existance now. Let me know if you think anything else needs to be updated.
Attachment #8357614 - Flags: review- → review?(bfrancis)
I commented on GitHub
No longer blocks: 946452
Component: Gaia → Gaia::Search
Comment on attachment 8357614 [details] [review]
Github pull request

Looks good by me
Attachment #8357614 - Flags: review?(dale) → review+
(Assignee)

Comment 7

4 years ago
Comment on attachment 8357614 [details] [review]
Github pull request

Thanks for the reviews guys. Ben - I've added guarding of the event, and I think it should suffice for now. We can certainly do more to enumerate the events if we want, but I don't see a particular need because the message is guarded by the manifest rules. I will happily review a pull request if this is of concern though.
Attachment #8357614 - Flags: review?(bfrancis)
(Assignee)

Comment 8

4 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/37a7e6c32b8c96c20bd07fa9a7892118d7cf278b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.