957943 - Fix intermittent failure of test_settings_wifi.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

When wifi has password and the wifi is out of screen, tap() action cannot show password page.


Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.2-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_wifi.py", line 26, in test_connect_to_wifi_via_settings_app
wifi_settings.connect_to_network(self.testvars['wifi'])
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/wifi.py", line 39, in connect_to_network
self.wait_for_element_displayed(*self._password_input_locator)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 71, in wait_for_element_displayed
raise TimeoutException('Element %s present but not displayed before timeout' % locator)
TimeoutException: Element #wifi-auth input[type="password"] present but not displayed before timeout

Comment 1

[Askeing Yen[:askeing][:fyen]]

0. prepare a target wifi ap with password
1. launch settings app, disable wifi
2. enable wifi, make sure the target wifi is out of screen
3. tap() wifi when it's out of screen, the tap() doesn't work
> self.marionette.find_element('xpath', "//li/a[text()='%s']" % network_info['ssid']).tap()
4. scroll the target wifi into view, the tap() works
> self.marionette.find_element('xpath', "//li/a[text()='%s']" % network_info['ssid']).tap()

Comment 2

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 15134

Comment 3

[Zac C (:zac)]

Comment on attachment 8357623 [details] [review]
PR 15134

r+

Comment 4

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/cb598383322b8e2eea4f67f4492f3da1c4b5b52a