Closed
Bug 957950
Opened 10 years ago
Closed 10 years ago
Codegen tempRoot scope refactoring and indentation fix
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: nsm, Assigned: nsm)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
3.88 KB,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
Scope for tempRoot is duplicated in the codegen and not indented nicely in the output.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8357648 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nsm.nikhil
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8357648 [details] [diff] [review] Refactor tempRoot scope in WebIDL codegen. r=me if you call it CGCallbackTempRoot and put it up higher in the file, right before that function that uses it.
Attachment #8357648 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8357648 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8357826 -
Flags: review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf236408019
https://hg.mozilla.org/mozilla-central/rev/fcf236408019
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•