Closed Bug 957976 Opened 6 years ago Closed 6 years ago

[Rocketbar] Use Everything.me Partners API

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: amirn, Assigned: amirn)

References

Details

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
Using the partners API will simplify working with E.me API and will de-couple the Search app from the Homescreen's E.me instance.
Blocks: 957978
Assignee: nobody → amirn
Attached file Github Commit (obsolete) —
Kevin, I fixed the tests except for 2 cases:
'make api call' in webresults_test.js and suggestions_test.js

Could you please have a look at it?

Thanks.
Attachment #8357711 - Flags: feedback?(kgrandon)
Attached file Github Pull Request
fixed tests and updated PR
Attachment #8357711 - Attachment is obsolete: true
Attachment #8357711 - Flags: feedback?(kgrandon)
Attachment #8357727 - Flags: review?(kgrandon)
Comment on attachment 8357727 [details] [review]
Github Pull Request

This looks great - I am excited to get it landed. I guess my main concern is around the passing of the apiKey during init. Why is this preferred over inclusion in some build step?
Attachment #8357727 - Flags: review?(kgrandon)
Flags: needinfo?(amirn)
It would also be good to have 100% unit test coverage for all of the new methods. I'm ok with a follow-up here, but let's open a bug to track it if we land without.
The shared apiKey is a temporary solution.

We plan to remove IAC completely in the next commit (Bug 957978) and share data using the Datastore API.
Exploring the Datastore API will probably take more time, and we want to land this ASAP to keep everyone on the same track.
Flags: needinfo?(amirn)
(In reply to Kevin Grandon :kgrandon from comment #4)
> It would also be good to have 100% unit test coverage for all of the new
> methods. I'm ok with a follow-up here, but let's open a bug to track it if
> we land without.

I am not sure which new methods you are referring to, but please file a new bug for anything you think should be tested and I will take it as a follow up.

Thanks!
updated PR per Kevin's comments.
Ok, I know you guys are taking off soon - so thanks for the PR. If I can I may try to get this landed and follow it up with some tests/IAC tweaks.
Comment on attachment 8357727 [details] [review]
Github Pull Request

Still some follow-up work to be done, but let's land and move quickly. Thanks for the nice patch!
Attachment #8357727 - Flags: review+
Landed: https://github.com/mozilla-b2g/gaia/commit/68bf96a8e4dc43acdcb5617f23d5d12f8a53068d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.