957978 - [Everything.me] Use Datastore to share information between Search and Homescreen E.me clients

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Comment 1

[Amir Nissim (:amirn)]

Attachment: Github Pull Request

Kevin, any feedback is always welcome :)

Comment 2

[Kevin Grandon :kgrandon]

Hi Amir - I have some concern over the strategy.. Could you please answer the following questions?

1 - What is deviceId used for on the backend? Is it used for tracking, results display, others?
2 - What future plans do we also plan on using the datastore for?
3 - Is this not something that we can generate and populate at build time instead?

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8359213 [details] [review]
Github Pull Request

I may be missing some context here, but from looking at the codebase, it seems that this should be part of the build system, not runtime. Please answer my above questions, and I can take another look. Thanks.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8359213 [details] [review]
Github Pull Request

Followed up with Ran this morning. I would rather use a build approach, but due to current requirements - it may not be possible. F+ from me, thanks for the clarifications.

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8359213 [details] [review]
Github Pull Request

Awesome

Comment 6

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/f26215c