Closed
Bug 957994
Opened 10 years ago
Closed 10 years ago
Add keyboard shortcut for searching
Categories
(Participation Infrastructure :: Phonebook, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: giorgos, Assigned: davidgf1987)
Details
(Whiteboard: [kb=1309597] [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation])
Define a keyboard shortcut that will focus on the search box for fast searches. Key 's' is a good candidate for "search".
Reporter | ||
Updated•10 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Reporter | ||
Updated•10 years ago
|
Whiteboard: [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com]
Updated•10 years ago
|
Whiteboard: [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com] → [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation]
Comment 2•10 years ago
|
||
Hi i am interested in working on this bug. Could you assign it to me and point me in the right direction. Thanks
Comment 3•10 years ago
|
||
Hi i am interested in working on this bug as part of a university project, can it be assigned to me please> Thank you
Reporter | ||
Comment 4•10 years ago
|
||
Thank you all for your interest and sorry for the late reply here, I somehow missed that bug until now. It's great we have so many hands to work on bugs but we'll have to process requests in order :) * farukuzun, are you still interested in this bug? If yes please reply here until Monday. * Liam, same for you. If you reply and farukuzun does not you'll get the bug * Jake, if nobody replies by Monday the bug is yours. Please reach out on irc.mozilla.org in #commtools channel and ping me to find you more bugs and / or suggest new features for the site. Thanks for offering to help!
Flags: needinfo?(farukuzun)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(liam)
Reporter | ||
Comment 6•10 years ago
|
||
OK Liam, you're the winner! Setup you local instance of mozillians and hack away. You can find documentation here mozillians.rtfd.org. The goal of this bug is to create a shortcut to focus on the searchbox on every page that has one. I believe that's actually all pages of mozillians.org. You can find us in #commtools on irc.mozilla.org if you have questions and/or want feedback on anything. Good luck!
Flags: needinfo?(farukuzun)
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → liam
Status: NEW → ASSIGNED
Comment 7•10 years ago
|
||
Hi Giorgos, here's my first attempt at fixing the bug :) https://github.com/liamkeily/mozillians/commit/9e00d39bbd8ffbe53f6bbd0362814cecb40dd6da
Flags: needinfo?(giorgos)
Comment 8•10 years ago
|
||
Liam, please go ahead and submit a pull request against the master branch of mozilla/mozillians. We usually use pull requests to review changes.
Comment 9•10 years ago
|
||
Ok done :) https://github.com/mozilla/mozillians/pull/795
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(giorgos)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation] → [kb=1286810] [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation]
Reporter | ||
Comment 10•10 years ago
|
||
Fixed here. https://github.com/mozilla/mozillians/commit/3aa12d377f6c4e976b2fe419df8d5a25d0192eb5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Version: other → next
Comment 11•10 years ago
|
||
QA verified on stage When viewing the homepage regardless of being logged in or not, typing the character 's' selects the search field and allows text input.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 12•10 years ago
|
||
This works perfectly everywhere, except when on the search page. https://mozillians.org/en-US/search/?q=mike Liam, do you want to fix this too?
Status: VERIFIED → REOPENED
Flags: needinfo?(liam)
Resolution: FIXED → ---
Updated•10 years ago
|
Version: next → other
Reporter | ||
Comment 13•10 years ago
|
||
Liam, since it's 10 days that you haven't replied I'm assuming that you're busy and that's totally fine. Thanks for the effort on this bug. Please ping us when you have the time to contribute to mozillians.org again. I'm re-assigning this bug to David who offered to help. Good luck!
Assignee: liam → davidgf1987
Flags: needinfo?(liam)
Assignee | ||
Updated•10 years ago
|
Status: REOPENED → ASSIGNED
Comment 14•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/84b720cde00f1f31d3ac9ee37869078ed5612a7c [fix bug 957994] Add key shortcut 's' to the search page. https://github.com/mozilla/mozillians/commit/b247628cb720221bffc780403162551a1183c885 Merge pull request #865 from davidgf/search_focus [fix bug 957994] Focus on search box when 's' key is pressed
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Version: other → next
Reporter | ||
Updated•10 years ago
|
Whiteboard: [kb=1286810] [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation] → [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation]
Reporter | ||
Updated•10 years ago
|
Whiteboard: [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation] → [kb=1309597] [difficulty=2/3][lang=html][lang=js][mentor=giorgos@mozilla.com][needsAutomation]
Reporter | ||
Comment 15•10 years ago
|
||
Shortcut now works on all pages, including the search page. Thanks David.
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•10 years ago
|
Version: next → 2014-03.4
You need to log in
before you can comment on or make changes to this bug.
Description
•