958005 - CSSKeyframesRule.findRule is treating the argument as a keyframe selector, not a number

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[ColCh]

Attachment: css3-animation-wront-args.html : file contains HTML page with script which demonstrates the bug

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

Coding css3 animation via JavaScript ---> filling keyframesRule exactly.

I try to find rule .. 

I'm passing DOMString as first argument.
Example : CSSKeyframesRule.findRule("0")

If I pass it with "%" postfix, it returns correct value
Example : CSSKeyframesRule.findRule("0%")

But "0%" is incorrect DOMString value.


Actual results:

CSSKeyframesRule.findRule returns null always with correct environment and correct arguments passed.




Expected results:

It should return correct CSSKeyframeRule (for DOMString like for postprefixed version).

Comment 1

[Boris Zbarsky [:bzbarsky]]

David, how stable is this part of the spec?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I really don't know. How well does it agree with implementations, and if there's disagreement, is the movement in one direction or another?

Comment 3

[ColCh]

Chrome has the same behavior.
IE - nope.

Please take a look at that, may be it can help:
http://lists.w3.org/Archives/Public/www-style/2013Feb/0587.html

Working Draft -> 19 February 2013
That mailing list -> 22 Feb 2013

So, may be they will update spec soon.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

If browsers agree, it makes more sense to change the spec than change all the browsers.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(Also, I think the argument being a keyframe selector makes a lot more sense than being a number.)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, agreed.  I guess we keep this open until the spec is fixed...

Comment 7

[ColCh]

Agreed too. IE throws an exception for wrong arg.
Still, a web-programmer can use simple workaround to make it work.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://dev.w3.org/csswg/css-animations/#interface-csskeyframesrule-findrule now says the argument is supposed to be a percentage value, which means our behavior is now correct.