958085 - Assertion failure: "Our containing block must not have unconstrained inline-size!"

Status: NEW

(Core :: Layout, defect, P5)

Description

[Paul Silaghi, QA [:pauly]]

Follow-up for bug 944909.

STR:
Open https://bugzilla.mozilla.org/attachment.cgi?id=8340654 (testcase from bug 944909)

AR: "###!!! ASSERTION: Bogus width: 'ComputedWidth() >= 0', file c:/builds/moz
2_slave/m-cen-w32-d-000000000000000000/build/layout/generic/nsHTMLReflowState.cp
p, line 2122"
Nightly 2014-01-09-mozilla-central-debug, Win 7 x64

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: reduced testcase 1

This can be triggered with just a tall <video> element, by itself.

Reduced testcase attached, which triggers the following debugging output when loaded:
{
###!!! ASSERTION: Bogus width: 'ComputedWidth() >= 0', file /mozilla-central/layout/generic/nsHTMLReflowState.cpp, line 2122
###!!! ASSERTION: width less than zero: 'aContainingBlockWidth >= 0', file /mozilla-central/layout/base/nsLayoutUtils.cpp, line 3281
###!!! ASSERTION: width less than zero: 'aContainingBlockWidth >= 0', file /mozilla-central/layout/base/nsLayoutUtils.cpp, line 3281
###!!! ASSERTION: width less than zero: 'aContainingBlockWidth >= 0', file /mozilla-central/layout/base/nsLayoutUtils.cpp, line 3281
###!!! ASSERTION: width less than zero: 'aContainingBlockWidth >= 0', file /mozilla-central/layout/base/nsLayoutUtils.cpp, line 3281
###!!! ASSERTION: bad width: 'metrics.Width() >= 0', file /mozilla-central/layout/generic/nsLineLayout.cpp, line 914
nsLineLayout: HTMLVideo(video)(0)@0x7fa980a1af58 metrics=0,1073741824!
###!!! ASSERTION: illegal width for combined area: 'aOverflowAreas.Overflow(otype).width >= 0', file /mozilla-central/layout/generic/nsLineBox.cpp, line 521
nsBlockReflowContext: Block(body)(1)@0x7fa980a1ac80 metrics=55740,1073741824!
WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../../dist/include/nsRect.h, line 95
WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../../dist/include/nsRect.h, line 95
WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../../dist/include/nsRect.h, line 95
WARNING: Overflowed nscoord_MAX in conversion to nscoord height: file ../../../dist/include/nsRect.h, line 95
}

Comment 2

[Negritas Sergiu, Desktop QA]

Hello! I have tried to reproduce the issue with firefox 126.0a1 on ubuntu 22.04 and unfortunately I wasn't able to reproduce the issue on my end with the link from the description.
I will mark this issue as RESOLVED->WORKSFORME, If this issue is still valid please feel free to reopen it.

Have a nice day

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Negritas Sergiu, Desktop QA from comment #2)

Hello! I have tried to reproduce the issue with firefox 126.0a1 on ubuntu 22.04 and unfortunately I wasn't able to reproduce the issue on my end with the link from the description.

Please don't close this. Note that this bug is about a C++ assertion failure, and assertions (###!!! ASSERTION: [...] someFile.cpp or Assertion failure: [...] someFile.cpp) are only enabled in debug builds, not in Nightlies. It sounds like maybe you were testing a Nightly which would explain why you didn't see any issues.

Running a debug build, I still see some assertion failures with the testcase linked in comment 0 and the attached reduced testcase, though the exact assertions have changed slightly in the last 10 years. This is what I get currently, from the linked & attached testcases:

###!!! ASSERTION: Our containing block must not have unconstrained inline-size!: 'aCBSize.ISize(aWM) != NS_UNCONSTRAINEDSIZE', file $SRC/layout/generic/nsContainerFrame.cpp:2377
###!!! ASSERTION: have unconstrained width or height; this should only result from very large sizes, not attempts at intrinsic size calculation: 'aPercentBasis != NS_UNCONSTRAINEDSIZE', file $SRC/layout/base/nsLayoutUtils.h:1520
###!!! ASSERTION: have unconstrained width or height; this should only result from very large sizes, not attempts at intrinsic size calculation: 'aPercentBasis != NS_UNCONSTRAINEDSIZE', file $SRC/layout/base/nsLayoutUtils.h:1520
WARNING: Unconstrained inline size; this should only result from huge sizes (not intrinsic sizing w/ orthogonal flows): 'aReflowInput.ComputedISize() != NS_UNCONSTRAINEDSIZE', file $SRC/layout/generic/nsFlexContainerFrame.cpp:4569
nsBlockReflowContext: FlexContainer(div)(1)@72585e20e298 metrics=1073741823,0!
nsBlockReflowContext: Block(div id=controlsContainer)(5)@72585e20e1d0 metrics=1073741823,0!
nsLineLayout: HTMLVideo(video)(0)@72585e20db38 metrics=1073741823,0!

--> updating bug title to reflect the first that we now fail with these testcases.