Closed Bug 958089 Opened 10 years ago Closed 10 years ago

Linux still has top padding in customize mode

Categories

(Firefox :: Theme, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: Gijs, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3][good first verify])

Attachments

(1 file)

We removed this on OS X and Windows; we should do the same on Linux.
Jared, what was the reason this padding was not removed on Linux?
Flags: needinfo?(jaws)
Attached patch PatchSplinter Review
I think it didn't get changed on Linux due to lack-of-love. The grid background does still show up on the TabsToolbar during customization, but it's unclear how it should look if that's not what we want.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8361641 - Flags: review?(mdeboer)
Flags: needinfo?(jaws)
Comment on attachment 8361641 [details] [diff] [review]
Patch

Review of attachment 8361641 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #8361641 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/29d3ddb3a1f0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Whiteboard: [Australis:P3] → [Australis:P3][good first verify]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: