Closed
Bug 958103
Opened 10 years ago
Closed 10 years ago
[Messages][Drafts] Don't auto-save drafts when message input is empty
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rwaldron, Assigned: rwaldron)
References
Details
Attachments
(1 file)
Per IRC report:
> [11:46:28] <Rik> I think the current behaviour is really annoying me because of the "go in a thread, press home button, that will create an empty draft"
This is certainly a bug!
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → waldron.rick
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8357847 -
Flags: review?(felash)
Attachment #8357847 -
Flags: feedback?(evelyn)
Attachment #8357847 -
Flags: feedback?(anthony)
|
|
Assignee | |
Updated•10 years ago
|
Summary: [Messages][Drafts] Don't auto-save empty drafts → [Messages][Drafts] Don't auto-save drafts when message input is empty
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8357847 [details] [review] https://github.com/mozilla-b2g/gaia/pull/15160 Looks good to me, pretty sure I meant to add it exactly this way at some point.
Attachment #8357847 -
Flags: feedback?(evelyn) → feedback+
|
||
Updated•10 years ago
|
Attachment #8357847 -
Flags: feedback?(anthony) → feedback+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8357847 [details] [review] https://github.com/mozilla-b2g/gaia/pull/15160 comments on github
|
|
||
Comment 4•10 years ago
|
||
Copying over some STR from 952514 to confirm in testing: STR1: * open "new message" view * press home * press the "messages" icon * press back Expected: * no new draft Actual: * a new draft was created STR2: * open "new message" view * add some text in the composer * press home * press the "messages" icon * press back * press "discard draft" Expected: * no new draft Actual: * a new draft was created
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8357847 [details] [review] https://github.com/mozilla-b2g/gaia/pull/15160 r=me, go for it :)
Attachment #8357847 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
landed https://github.com/mozilla-b2g/gaia/commit/1e41341d97efac2c303dced3dd0134999e008cb1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•10 years ago
|
||
This STR2 above is not valid according to the spec: STR2: * open "new message" view * add some text in the composer * press home * press the "messages" icon * press back * press "discard draft" Expected: * no new draft Actual: * a new draft was created Julien, can you please discuss with Ayman and decide exactly what should happen in that case?
Flags: needinfo?(felash)
Flags: needinfo?(aymanmaat)
|
||
Comment 10•10 years ago
|
||
(In reply to Evelyn Eastmond [:evhan55] from comment #4) > Copying over some STR from 952514 to confirm in testing: > > STR1: > * open "new message" view > * press home > * press the "messages" icon > * press back > > Expected: > * no new draft > > Actual: > * a new draft was created Expected is correct behaviour as message has no content is present in either the ‘message field’ or the ‘to field’ and therefore there is no draft to save. > > STR2: > * open "new message" view > * add some text in the composer > * press home > * press the "messages" icon > * press back > * press "discard draft" > > Expected: > * no new draft > > Actual: > * a new draft was created Expected is correct behaviour.
Flags: needinfo?(aymanmaat)
|
|
||
Comment 11•10 years ago
|
||
Bug 959196 was filed by Evelyn to address STR2.
You need to log in
before you can comment on or make changes to this bug.
Description
•