958117 - [ngreports] Report list on profile UX update

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Giorgos Logiotatidis [:giorgos]]

Attachment: Mozilla Reps - Profile of seadog 2014-01-09 19-04-56.png

The list of NGReports on profile needs some UX love:

 * Display the NGReports table along with the Reports table
 * Only Display the NGReports if waffle flag ('reports_ng_report') for the user _requesting_ the page is True
 * When a report is about participating in a campain we print "Participated in a campaign" which isn't descriptive enough. See attached screenshot. Instead we should print "Participated in campaign '<campaign name>'"
 * Similarly for events
 * "Date" column displays the date Rep reported the action happened (not the date report was added in the database) while we sort by the date report was added in the database. I suggest we print the date added in the database.

Comment 1

[William Reynolds [:williamr]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #0)
>  * "Date" column displays the date Rep reported the action happened (not the
> date report was added in the database) while we sort by the date report was
> added in the database. I suggest we print the date added in the database.

I suggest we print and sort by the contribution date, which is when the Rep actually did their activity. Our reports store the contribution date and the submission date (when the Rep filled out the form and added to the database). I think it makes sense to order activities by when they happened rather than when they reported. I believe that order will be more useful for mentors and someone wanting to see what a Rep has recently done.

I think it would be helpful to display the contribution dates in this section in a relative time format. For example: 3 days ago, 2 weeks ago, 1 month ago, etc. This would replace the "09 Jan 2014" format shown in attachment 8357833 [details].

Comment 2

[Giorgos Logiotatidis [:giorgos]]

(In reply to William Reynolds [:williamr] from comment #1)
> (In reply to Giorgos Logiotatidis [:giorgos] from comment #0)
> >  * "Date" column displays the date Rep reported the action happened (not the
> > date report was added in the database) while we sort by the date report was
> > added in the database. I suggest we print the date added in the database.
> 
> I suggest we print and sort by the contribution date, which is when the Rep
> actually did their activity. Our reports store the contribution date and the
> submission date (when the Rep filled out the form and added to the
> database). I think it makes sense to order activities by when they happened
> rather than when they reported. I believe that order will be more useful for
> mentors and someone wanting to see what a Rep has recently done.
> 

That works too. My only concern about this is that if a user added activity X that happened on Wed and then on Thu adds an activity that happened on Mon, the latter will be listed after the first.

In other words what I'm saying is that this is a list of actions taken in the site (that reflect contributions) and it's not ordered using site's timestamp, which may be confusing.

But either way I think it's going to be OK. 

Also with the way William suggests we will be able to hide reports regarding events that have not come to date yet. This will happen when a user click the "attend event" button for an upcoming event. So I agree let's go with William's suggestion

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/5191a158047b4cef3895c9c70a89896924076020
[fix bug 958117] UX update on new generation report listing on user's profile.

https://github.com/mozilla/remo/commit/925899b2e365abaa7eec52d15767b8991a66e994
Merge pull request #585 from akatsoulas/958117

[fix bug 958117] UX update on new generation report listing on user's pr...

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/2a13d83cc532b199025e9e1b49862f4c2a573b30
[bug 958117] Add title to report list.

https://github.com/mozilla/remo/commit/ebdcd145b62360c9a07aa96456722fc67ceb0861
Merge pull request #588 from glogiotatidis/958117

[bug 958117] Add title to report list.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

Verified on stage:
 - NGreports table appears conditionally based on the reports_ng_report waffle flag
 - NGreports are listed in order of creation and we display the date of the activity
 - Relative time format in place ("1 minute ago")
 - Event and Campaign passive reports have more context 'Attended event "foo"'

Thanks :tasos!