[Camera] fxos specific APIs need to be mocked in order to renable some of the unit tests

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dmarcos, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
dmarcos
: review+
Details | Review | Splinter Review
(Reporter)

Description

5 years ago
We have disabled several of the unit tests that were failing in travis. Some of the fxos specific APIs have to be mocked before renabling the tests. Below links to the travis results containing the errors:

https://travis-ci.org/mozilla-b2g/gaia/jobs/16619099

Error messages:

TypeError: navigator.getDeviceStorage is not a function
TypeError: Cannot stub non-existent own property mozHasPendingMessage
Error: global leak detected: debug
(Assignee)

Updated

5 years ago
Assignee: nobody → wilsonpage
(Assignee)

Comment 1

5 years ago
Created attachment 8359813 [details] [review]
Pull Request
Attachment #8359813 - Flags: review?(dmarcos)
(Reporter)

Comment 2

5 years ago
Created attachment 8360554 [details] [review]
Pull Request
Attachment #8359813 - Attachment is obsolete: true
Attachment #8359813 - Flags: review?(dmarcos)
Attachment #8360554 - Flags: review?(dmarcos)
(Reporter)

Comment 3

5 years ago
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/6cf2caea1ffb04255ccd6f43b79be93d8aa4d611
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Attachment #8360554 - Flags: review?(dmarcos) → review+
You need to log in before you can comment on or make changes to this bug.