Closed Bug 958155 Opened 10 years ago Closed 10 years ago

AutoBool should be replaced with AutoRestore<bool>, in AutoMounter.cpp

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 931424

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

It looks like the class "AutoBool", added here:
 http://hg.mozilla.org/mozilla-central/rev/44b92484bfe6
can & should be replaced with an instance of AutoRestore<bool>, documented here:
 http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/AutoRestore.h#16
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch untested fixSplinter Review
Haven't compiled this yet, but I think this should do it.
[cool, it compiles successfully]

But in reading more of the bug that added AutoBool, I see that this is a dupe of bug 931424, which looks like it has a ready-to-land patch that's been sitting for 2 months.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: