Inspector actor should use DevToolsUtils.makeInfallible instead of reinventing its own

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Developer Tools: Inspector
P3
normal
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: fitzgen, Assigned: nchevobbe)

Tracking

unspecified
Firefox 49
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

It is reinvented here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/inspector.js#95

But should just use this one:

http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/DevToolsUtils.js#70
(Assignee)

Comment 1

2 years ago
(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #0)
> It is reinvented here:
> 
> http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> inspector.js#95
> 
> But should just use this one:
> 
> http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/DevToolsUtils.
> js#70

Provided links don't work anymore.
Here is the reinvented function : https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/inspector.js#143
And the one we should use : https://dxr.mozilla.org/mozilla-central/source/devtools/shared/ThreadSafeDevToolsUtils.js#98
Priority: -- → P3
(Assignee)

Comment 2

2 years ago
Created attachment 8750056 [details]
MozReview Request: Bug 958167 - Use Inspector DevToolsUtils.makeInfallible in inspector actor instead of its own version. r=fitzgen

Review commit: https://reviewboard.mozilla.org/r/51287/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51287/
Attachment #8750056 - Flags: review?(nfitzgerald)
(Assignee)

Updated

2 years ago
Assignee: nobody → chevobbe.nicolas
Status: NEW → ASSIGNED
https://reviewboard.mozilla.org/r/51285/#review48123

Ship it!

::: devtools/server/actors/inspector.js
(Diff revision 1)
>  });
>  
>  loader.lazyGetter(this, "CssLogic", () => require("devtools/shared/inspector/css-logic").CssLogic);
>  
> -// XXX: A poor man's makeInfallible until we move it out of transport.js
> -// Which should be very soon.

LOL this is an out of date comment if I've ever seen one
Attachment #8750056 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8750056 [details]
MozReview Request: Bug 958167 - Use Inspector DevToolsUtils.makeInfallible in inspector actor instead of its own version. r=fitzgen

https://reviewboard.mozilla.org/r/51287/#review48125
(Assignee)

Comment 5

2 years ago
(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #3)
> https://reviewboard.mozilla.org/r/51285/#review48123
> 
> Ship it!
> 
> ::: devtools/server/actors/inspector.js
> (Diff revision 1)
> >  });
> >  
> >  loader.lazyGetter(this, "CssLogic", () => require("devtools/shared/inspector/css-logic").CssLogic);
> >  
> > -// XXX: A poor man's makeInfallible until we move it out of transport.js
> > -// Which should be very soon.
> 
> LOL this is an out of date comment if I've ever seen one

Came across this while triaging, and it kind of bother me as I was working on inspector.js ;)

checkin-needed added as TRY is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=151fcef85356 (except one known intermittent)
Keywords: checkin-needed

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/a3033ed384eb
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a3033ed384eb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.