Closed
Bug 958233
Opened 12 years ago
Closed 12 years ago
add remixurl and editurl attributes to makes
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
References
Details
(Whiteboard: preworkweek)
Attachments
(1 file)
No description provided.
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8357981 -
Flags: review?(jon)
Comment 2•12 years ago
|
||
Comment on attachment 8357981 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/407
You should also remove the S3 publishing bit for the /edit and /remix URLs
Attachment #8357981 -
Flags: review?(jon) → review-
| Assignee | ||
Updated•12 years ago
|
Attachment #8357981 -
Flags: review- → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 8357981 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/407
.... I think I meant to put this up for review?
Attachment #8357981 -
Flags: review+ → review?(jon)
Updated•12 years ago
|
Attachment #8357981 -
Flags: review?(jon) → review-
| Assignee | ||
Updated•12 years ago
|
Attachment #8357981 -
Flags: review- → review?(jon)
| Assignee | ||
Updated•12 years ago
|
Whiteboard: preworkweek
Comment 4•12 years ago
|
||
Comment on attachment 8357981 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/407
Some nits to clean up, but this looks good
Attachment #8357981 -
Flags: review?(jon) → review+
Comment 5•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/4b1888f28d66bc29432521ac76872ed4dc215e73
Bug 958233 - add remixurl and editurl to makeapi record
| Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•