958236 - reviewboard.allizom.org is not sending emails

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Gregory Szorc [:gps]]

ReviewBoard supports sending emails when updates occur. We're conducting a review on https://reviewboard.allizom.org/r/22/ and I have not seen any emails in my inbox. I don't see an option to enable emails for my account.

IMO ReviewBoard without notifications is not usable.

Can we please enable email updates on our ReviewBoard instance?

Comment 1

[Mark Côté [:mcote]]

This something you can handle, fubar?

Comment 2

[Kendall Libby [:fubar] (he/him)]

I'm not sure it was necessarily required, but I've added the postfix satellite setup. Looks like the rest is reviewboard settings: https://reviewboard.allizom.org/admin/settings/email/

Enabled sending messages for review requests and reviews, and when review requests are closed; I think sending via smtp.mozilla.org will work, but if someone could test and let me know, that'd be spiffy (or, if not, so I can go check the logs).

Comment 3

[Gregory Szorc [:gps]]

I just added a comment to https://reviewboard.allizom.org/r/24/ and didn't receive an email.

Comment 4

[Kendall Libby [:fubar] (he/him)]

[Fri Jan 10 16:29:46 2014] [error] ERROR:root:Error sending e-mail notification 
with subject 'Re: Review Request 24: Bug 875562 - Part 4: Add Support for crash 
event files to CrashManager' on behalf of '"Gregory Szorc [:gps]" <>' to '"Benja
min Smedberg  [:bsmedberg]" <>,"Ted Mielczarek [:ted.mielczarek]" <>,"Gregory Sz
orc [:gps]" <>': {'"Gregory Szorc \\\\[:gps\\\\]" <>': (501, '5.1.3 Bad recipien
t address syntax'), '"Ted Mielczarek \\\\[:ted.mielczarek\\\\]" <>': (501, '5.1.
3 Bad recipient address syntax'), '"Benjamin Smedberg  \\\\[:bsmedberg\\\\]" <>'
: (501, '5.1.3 Bad recipient address syntax')}

Yeah, sending to :ircnick isn't going to work very well. Looks like the email address fields aren't populated for users in Reviewboard. :mcote, tag, you're it.

Comment 5

[Mark Côté [:mcote]]

Aha oops.  Okay, I uploaded a new egg to the same place with that fix (https://people.mozilla.com/~mcote/ReviewBoard-1.7.19.dev-py2.7.egg).  I discovered another problem, namely, that if a Bugzilla user changes their email, a new Review Board user will be created instead of the old one being updated, since I key off of the username when querying the db.  It's not a huge deal right now, but I'll fix it eventually.

Note that I am on PTO for two weeks starting Monday.  This was a tiny change so everything should be fine.  If you run into problems deploying it, ping smacleod or mconley I guess.

Comment 6

[Kendall Libby [:fubar] (he/him)]

Updated with the new egg. :gps, let us know if it works or doesn't?

Comment 7

[Gregory Szorc [:gps]]

I submitted a comment about 2 minutes ago and haven't received anything yet :/

Comment 8

[Kendall Libby [:fubar] (he/him)]

[Thu Jan 23 20:12:06 2014] [error] SMTPRecipientsRefused: {'"Gregory Szorc \\\\[:gps\\\\]" <>': (501, '5.1.3 Bad recipient address syntax'), '"Ted Mielczarek \\\\[:ted.mielczarek\\\\]" <>': (501, '5.1.3 Bad recipient address syntax'), '"Benjamin Smedberg  \\\\[:bsmedberg\\\\]" <>': (501, '5.1.3 Bad recipient address syntax')}

So, still in :mcote's court.

Comment 9

[Mark Côté [:mcote]]

Ah blah, of course, those users were added before this change.  Hm.  I guess I'll have to add something that checks if a user's email is blank each time a user is fetched from the db.  Not much else I can do aside from wiping the db.  I'll work on that shortly.

Comment 10

[Mark Côté [:mcote]]

I was overthinking things; I just need fubar to copy the username column over to the email column for all entries in the auth_user table where email is blank.

Comment 11

[Kendall Libby [:fubar] (he/him)]

Ok, should be good to go. Test away...

Comment 12

[Mike Conley (:mconley) (:⚙️)]

I just received email from Review Board! Did you get what I sent, gps?

Comment 13

[Gregory Szorc [:gps]]

I received an email \o/

Comment 14

[Mark Côté [:mcote]]

I guess this is resolved!