Closed
Bug 958243
Opened 12 years ago
Closed 12 years ago
unregisterEventListener calls in GeckoApp are out of sync
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Details
Attachments
(1 file)
|
1.96 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
I noticed this while grepping through some fennec code. (Maybe it'd be safer to store these in an array of strings, then loop through it for both registration and unregistration?)
Attachment #8357957 -
Flags: review?(mark.finkle)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8357957 [details] [diff] [review]
patch
>diff --git a/mobile/android/base/GeckoApp.java b/mobile/android/base/GeckoApp.java
>- unregisterEventListener("Tab:ViewportMetadata");
I see this registered in Tabs.java, but we don't seem to unregister anything in Tabs.java so I am OK with this change
Attachment #8357957 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•