958341 - Present "login motivation" to Android FxAccountClient /account/create call to support email verification UI and metrics

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

This might look like an additional flag to the API endpoint, like /account/create?service=sync or /account/login?service=sync.  We'll need to support this at the HTTP client level and at the Fennec level.

Comment 1

[Katie Parlante]

:nalexander, lets put this back on the radar now that we have more services coming online. Its helpful for two reasons:
- The verification email & verification confirm page can be customized appropriately per service
- We have a window into which services drive account creation

Specifically, add "service=sync" to these endpoints (from https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md):
- /account/create
- /password/forgot/send_code
- /password/forgot/resend_code
- /recovery_email/send_code

Not sure if Android calls the password/recovery endpoints, so I went ahead and listed all of them. Note that its not needed for the login endpoint, as no email gets sent.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/475

rnewman is PTO for another week, but this isn't urgent (to me).  kparlante, you can redirect to mcomella if you want faster review.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8474809 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/475

Reviewed on GitHub.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/ff9659baf12b

Comment 5

[Nick Alexander :nalexander [he/him]]

In local testing, I created a new account and saw:

3878:D FxAccounts(25174)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/create?service=sync&keys=true

In my logs.  Hope that works, kparlante!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff9659baf12b