Closed Bug 958341 Opened 6 years ago Closed 6 years ago

Present "login motivation" to Android FxAccountClient /account/create call to support email verification UI and metrics

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 34

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa?])

Attachments

(1 file)

This might look like an additional flag to the API endpoint, like /account/create?service=sync or /account/login?service=sync.  We'll need to support this at the HTTP client level and at the Fennec level.
Summary: Present "login motivation" to auth server /account/login call to support metrics → Present "login motivation" to Android FxAccountClient /account/{create,login} call to support metrics
Whiteboard: [qa?]
:nalexander, lets put this back on the radar now that we have more services coming online. Its helpful for two reasons:
- The verification email & verification confirm page can be customized appropriately per service
- We have a window into which services drive account creation

Specifically, add "service=sync" to these endpoints (from https://github.com/mozilla/fxa-auth-server/blob/master/docs/api.md):
- /account/create
- /password/forgot/send_code
- /password/forgot/resend_code
- /recovery_email/send_code

Not sure if Android calls the password/recovery endpoints, so I went ahead and listed all of them. Note that its not needed for the login endpoint, as no email gets sent.
Flags: needinfo?(nalexander)
Summary: Present "login motivation" to Android FxAccountClient /account/{create,login} call to support metrics → Present "login motivation" to Android FxAccountClient /account/create call to support email verification UI and metrics
rnewman is PTO for another week, but this isn't urgent (to me).  kparlante, you can redirect to mcomella if you want faster review.
Attachment #8474809 - Flags: review?(rnewman)
Flags: needinfo?(nalexander)
Comment on attachment 8474809 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/475

Reviewed on GitHub.
Attachment #8474809 - Flags: review?(rnewman) → review+
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
In local testing, I created a new account and saw:

3878:D FxAccounts(25174)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/create?service=sync&keys=true

In my logs.  Hope that works, kparlante!
https://hg.mozilla.org/mozilla-central/rev/ff9659baf12b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.