Closed Bug 958395 Opened 6 years ago Closed 6 years ago

Error running "mach mochitest-plain" on desktop

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: roc, Assigned: ahal)

References

Details

Attachments

(1 file)

[roc@eternity mozilla-inbound]$ MOZCONFIG=~/.mozconfig-ff-debug ./mach mochitest-plain layout/forms/test/test_bug957562.html 
From _tests: Kept 13870 existing; Added/updated 0; Removed 0 files and 0 directories.
Error running mach:

    ['mochitest-plain', 'layout/forms/test/test_bug957562.html']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: run_desktop_test() got an unexpected keyword argument 'hide_subtests'

  File "/home/roc/mozilla-inbound/testing/mochitest/mach_commands.py", line 564, in run_mochitest_plain
    return self.run_mochitest(test_file, 'plain', **kwargs)
  File "/home/roc/mozilla-inbound/testing/mochitest/mach_commands.py", line 619, in run_mochitest
    **kwargs)
Indeed, run_desktop_test doesn't take a hide_subtests argument.
Bugs in mach commands are filed under the bugzilla component the command deals with.
Component: mach → Mochitest
Product: Core → Testing
Blocks: 957768
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Of course I tested my patch with a b2g_desktop build, and of course that mach target is implemented slightly differently.

Sorry about that.
Attachment #8358389 - Flags: review?(jmaher)
Comment on attachment 8358389 [details] [diff] [review]
Patch 1.0 - make mochitest-plain mach target process kwargs

Review of attachment 8358389 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for looking into this.  Have we covered all the b2g, desktop, android cases for mach and test runners now?
Attachment #8358389 - Flags: review?(jmaher) → review+
Yeah, it's just the two for now. Android doesn't have a mach target for mochitest yet.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7383e6a8604
https://hg.mozilla.org/mozilla-central/rev/a7383e6a8604
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.