Closed Bug 958412 Opened 10 years ago Closed 10 years ago

[Gaia][DSDS] move simcard detection logic to system app

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C3/1.4 S3(31jan)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: eragonj, Assigned: eragonj)

References

Details

Attachments

(2 files)

patch on master
46 bytes, text/x-github-pull-request
alive
: review+
arthurcc
: review+
Details | Review
patch on v1.3
46 bytes, text/x-github-pull-request
Details | Review 
It seems that we checked SIM status to set defaultId in SimCardManager. But after discussion with Arthur, we thought this logic should be moved to system app in order to set on right defaultId when bootup.
blocking-b2g: --- → 1.3?
1.4?

Can we make the change in 1.4 instead? Its rather late in 1.3
blocking-b2g: 1.3? → 1.4?
Because this block bug 962964, set 1.3? for this bug.
blocking-b2g: 1.4? → 1.3?
Block the blocker.
blocking-b2g: 1.3? → 1.3+
Attached file patch on v1.3 — 
this patch has the same code changes like master.patch. I just want to make sure Travis passes all tests in v1.3 as well.
Comment on attachment 8365755 [details] [review]
patch on master

Hi Alive and Arthur,

can you help me review this patch on master ? 

Thanks :)

(patch on v1.3 is the same with patches on master, so we don't need to r? v1.3 patch)
Attachment #8365755 - Flags: review?(arthur.chen)
Attachment #8365755 - Flags: review?(alive)
Whiteboard: dsdsrun1.3-2
Comment on attachment 8365755 [details] [review]
patch on master

r=me for the settings part. The system part also looks good to me. Thanks for the patch!
Attachment #8365755 - Flags: review?(arthur.chen) → review+
Alive, I need your help on this patch.

Please help me review this because it is a v1.3 blocker LOL 

Big Thanks !!! :D
Flags: needinfo?(alive)
Comment on attachment 8365755 [details] [review]
patch on master

r+ with nits
Attachment #8365755 - Flags: review?(alive) → review+
Flags: needinfo?(alive)
Thanks all ! 

Patches are landed on 

Gaia/master : 9b66f2dd2580e6fc916d1daa21a2ac061ac92bee
Gaia/v1.3 : 4fee35084aa963e07a8192a38445ce57c9fc83a3
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v1.3: --- → fixed
status-firefox29: --- → fixed
Resolution: --- → FIXED
Whiteboard: dsdsrun1.3-2
status-b2g-v1.3T: --- → fixed
status-b2g-v1.4: --- → fixed
status-firefox29: fixed → ---
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: