958464 - Client support for tokenserver "invalid-generation" response.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

To speed up the propagation of password changes, the FxA server will include a "generation number" in all identity certificates that it issues.  This is an integer that will increase monotonically with each change of the user's password.

If the tokenserver received an assertion with an old generation number, it will reject it with an "invalid-generation" response as described in Bug 958462.

The client needs to detect this response and fetch a fresh identity certificate from the FxA auth server.  Which almost certainly entails re-prompting the user for their updated password.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: Report cause of 401 error (invalid-generation, etc.)

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

When a 401 is returned by the token server, TokenServerClient.getTokenFromBrowserIDAssertion() will call back with an error that includes the cause, e.g., invalid-generation.

It looks like the only place this method is invoked is in browserid_identity.js [1] where the error will be caught and cause the _fetchTokenForUser() promise to be rejected.

Mark, is this enough to get the info you need for the UI bits?

[1] https://mxr.mozilla.org/mozilla-central/source/services/sync/modules/browserid_identity.js#308

Comment 3

[Chris Karlof [:ckarlof]]

yes

Comment 4

[Chris Karlof [:ckarlof]]

Comment on attachment 8366941 [details] [diff] [review]
Report cause of 401 error (invalid-generation, etc.)

Review of attachment 8366941 [details] [diff] [review]:
-----------------------------------------------------------------

Mark Hammond r+ over my shoulder

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Hella dope.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d8d2ac7002ff

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8d2ac7002ff